Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2689004: Convert 'char *' to 'char*' throughout power manager. (Closed)

Created:
10 years, 6 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
tfarina, Sameer Nanda
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/power_manager.git
Visibility:
Public.

Description

Convert 'char *' to 'char*' throughout power manager. Many of these were pointed out by tfarina. BUG=none TEST=Ran test suite

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M backlight_controller.h View 1 chunk +1 line, -1 line 2 comments Download
M backlight_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M power_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M power_prefs.cc View 1 chunk +1 line, -1 line 3 comments Download
M power_prefs_interface.h View 1 chunk +1 line, -1 line 1 comment Download
M powerd.cc View 2 chunks +4 lines, -4 lines 2 comments Download
M powerd_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
davidjames
10 years, 6 months ago (2010-06-05 00:48:13 UTC) #1
tfarina
LGTM! Thanks David! http://codereview.chromium.org/2689004/diff/1/3 File backlight_controller.h (right): http://codereview.chromium.org/2689004/diff/1/3#newcode72 backlight_controller.h:72: int64 clamp(int64 x) { return std::min(100LL, ...
10 years, 6 months ago (2010-06-05 01:08:56 UTC) #2
tfarina
http://codereview.chromium.org/2689004/diff/1/3 File backlight_controller.h (right): http://codereview.chromium.org/2689004/diff/1/3#newcode60 backlight_controller.h:60: int64 plugged_brightness_offset() { return plugged_brightness_offset_; } I really would ...
10 years, 6 months ago (2010-06-05 01:10:26 UTC) #3
Sameer Nanda
10 years, 6 months ago (2010-06-07 01:44:23 UTC) #4
LGTM

On Fri, Jun 4, 2010 at 5:48 PM, <davidjames@chromium.org> wrote:

> Reviewers: tfarina, sameer,
>
> Description:
> Convert 'char *' to 'char*' throughout power manager.
>
> Many of these were pointed out by tfarina.
>
> BUG=none
> TEST=Ran test suite
>
> Please review this at http://codereview.chromium.org/2689004/show
>
> SVN Base: ssh://git@chromiumos-git/power_manager.git
>
> Affected files:
>  M backlight_controller.h
>  M backlight_controller.cc
>  M power_prefs.h
>  M power_prefs.cc
>  M power_prefs_interface.h
>  M powerd.cc
>  M powerd_unittest.cc
>
>
>


-- 
Sameer

Powered by Google App Engine
This is Rietveld 408576698