Convert 'char *' to 'char*' throughout power manager.

Convert 'char *' to 'char*' throughout power manager.

Many of these were pointed out by tfarina.

BUG=none
TEST=Ran test suite

[tfarina, 2010-06-05 01:08:56]

LGTM! Thanks David!

http://codereview.chromium.org/2689004/diff/1/3
File backlight_controller.h (right):

http://codereview.chromium.org/2689004/diff/1/3#newcode72
backlight_controller.h:72: int64 clamp(int64 x) { return std::min(100LL,
std::max(0LL, x)); }
In a follow up patch, maybe could we rename this to Clamp?

http://codereview.chromium.org/2689004/diff/1/4
File power_prefs.cc (right):

http://codereview.chromium.org/2689004/diff/1/4#newcode10
power_prefs.cc:10: #include "base/file_util.h"
sort these alphabetical.

http://codereview.chromium.org/2689004/diff/1/4#newcode13
power_prefs.cc:13: using std::string;
can we get rid of this using? there are just to cases below.

http://codereview.chromium.org/2689004/diff/1/4#newcode21
power_prefs.cc:21: FilePath path = base_path_.Append(setting_name);
David, I was going to do this change, but since I'm still unable to build it,
could change this to AppendASCII? Same below.

http://codereview.chromium.org/2689004/diff/1/6
File power_prefs_interface.h (right):

http://codereview.chromium.org/2689004/diff/1/6#newcode23
power_prefs_interface.h:23: };
maybe add a DISALLOW_EMPTY_CONSTRUCTORS here? Hum, since this is an interface, I
think it's ok. Up to you.

http://codereview.chromium.org/2689004/diff/1/7
File powerd.cc (right):

http://codereview.chromium.org/2689004/diff/1/7#newcode50
powerd.cc:50: void*) {
I know we are not using this paramenter, but would be good to add one at least
:)

http://codereview.chromium.org/2689004/diff/1/7#newcode300
powerd.cc:300: 
remove this blank line;

[tfarina, 2010-06-05 01:10:26]

http://codereview.chromium.org/2689004/diff/1/3
File backlight_controller.h (right):

http://codereview.chromium.org/2689004/diff/1/3#newcode60
backlight_controller.h:60: int64 plugged_brightness_offset() { return
plugged_brightness_offset_; }
I really would like to make this and the below getter accessor const. Would be
good for a next CL though.

[Sameer Nanda, 2010-06-07 01:44:23]

LGTM

On Fri, Jun 4, 2010 at 5:48 PM, <davidjames@chromium.org> wrote:

> Reviewers: tfarina, sameer,
>
> Description:
> Convert 'char *' to 'char*' throughout power manager.
>
> Many of these were pointed out by tfarina.
>
> BUG=none
> TEST=Ran test suite
>
> Please review this at http://codereview.chromium.org/2689004/show
>
> SVN Base: ssh://git@chromiumos-git/power_manager.git
>
> Affected files:
>  M backlight_controller.h
>  M backlight_controller.cc
>  M power_prefs.h
>  M power_prefs.cc
>  M power_prefs_interface.h
>  M powerd.cc
>  M powerd_unittest.cc
>
>
>


-- 
Sameer