Issue 26890002: Fix uninitialized memory read in BitmapCopy test with A1 config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26890002: Fix uninitialized memory read in BitmapCopy test with A1 config (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix uninitialized memory read in BitmapCopy test with A1 config

Patch Set 2 : Switched to use getSafeSize #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tests/BitmapCopyTest.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm https://codereview.chromium.org/26890002/diff/1/tests/BitmapCopyTest.cpp File tests/BitmapCopyTest.cpp (right): https://codereview.chromium.org/26890002/diff/1/tests/BitmapCopyTest.cpp#newcode63 tests/BitmapCopyTest.cpp:63: memset(bitmap.getPixels(), 0xff, bitmap.getSize()); getSafeSize()?

7 years, 2 months ago (2013-10-10 17:53:47 UTC) #2

robertphillips

7 years, 2 months ago (2013-10-10 22:01:37 UTC) #3

Message was sent while issue was closed.

committed as r11722

https://codereview.chromium.org/26890002/diff/1/tests/BitmapCopyTest.cpp
File tests/BitmapCopyTest.cpp (right):

https://codereview.chromium.org/26890002/diff/1/tests/BitmapCopyTest.cpp#newc...
tests/BitmapCopyTest.cpp:63: memset(bitmap.getPixels(), 0xff, bitmap.getSize());
On 2013/10/10 17:53:47, reed1 wrote:
> getSafeSize()?

Done.

Expand Messages | Collapse Messages

Issue 26890002: Fix uninitialized memory read in BitmapCopy test with A1 config (Closed)

Description

Patch Set 1 #

Patch Set 2 : Switched to use getSafeSize #

Messages