chrome/android/shared_preference_files/vr_cardboard_skipdon_setupcomplete.json - Issue 2688913003: Add shared preference file modification option to instrumentation test runner

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/shared_preference_files/vr_cardboard_skipdon_setupcomplete.json

Issue 2688913003: Add shared preference file modification option to instrumentation test runner (Closed)

Patch Set: Address jbudorick@ comments in local_device_instrumentation_test_run.py Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 [
	jbudorick 2017/02/16 02:57:09 nit: I think these should have a /test/ directory nit: I think these should have a /test/ directory in their path somewhere to make it clear that they're specifically files for use in testing. Otherwise, it's not clear that that's the case. bsheedy 2017/02/16 18:04:50 Done. Show quoted text On 2017/02/16 02:57:09, jbudorick wrote: > nit: I think these should have a /test/ directory in their path somewhere to > make it clear that they're specifically files for use in testing. Otherwise, > it's not clear that that's the case. Done.
	2 {

	3 "package": "com.google.vr.vrcore",

	4 "filename": "VrCoreSettings.xml",

	5 "set": {

	6 "VrSkipDon": true,

	7 "DaydreamSetupComplete": true,

	8 "VrDeviceParams": "CgZHb29nbGUSCUNhcmRib2FyZB0J-SA9JQHegj0qEAAAcEIAAHBCAAB wQgAAcEI1KVwPPToIV_GrPmKxDT9QAFgAYAM"

	9 }

	10 }

	11 ]

OLD	NEW