Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: bench/gen_bench_expectations.py

Issue 268883002: Use a separate error parameter for lower bound. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_expectations.py
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index e7d08d116f6d57b1712ef10f71ac4efd18cfa498..6a5ee1e371f55557c53252062e099b669e669d01 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -15,7 +15,8 @@ import sys
RANGE_RATIO_UPPER = 1.2 # Ratio of range for upper bounds.
RANGE_RATIO_LOWER = 2.0 # Ratio of range for lower bounds.
ERR_RATIO = 0.08 # Further widens the range by the ratio of average value.
-ERR_ABS = 0.5 # Adds an absolute error margin to cope with very small benches.
+ERR_UB = 0.5 # Adds an absolute upper error to cope with small benches.
+ERR_LB = 1.5
# List of bench configs to monitor. Ignore all other configs.
CONFIGS_TO_INCLUDE = ['simple_viewport_1000x1000',
@@ -43,8 +44,8 @@ def compute_ranges(benches):
diff = maximum - minimum
avg = sum(benches) / len(benches)
- return [minimum - diff * RANGE_RATIO_LOWER - avg * ERR_RATIO - ERR_ABS,
- maximum + diff * RANGE_RATIO_UPPER + avg * ERR_RATIO + 2 * ERR_ABS]
+ return [minimum - diff * RANGE_RATIO_LOWER - avg * ERR_RATIO - ERR_UB,
+ maximum + diff * RANGE_RATIO_UPPER + avg * ERR_RATIO + ERR_LB]
def create_expectations_dict(revision_data_points):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698