Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: runtime/lib/stacktrace.cc

Issue 2688783002: Fix missing top frame in exception stacks in product mode (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/stacktrace.cc
diff --git a/runtime/lib/stacktrace.cc b/runtime/lib/stacktrace.cc
index 9528a10ba477c9c8218fcb400574b4ff4deeb2f1..7f9c146b5d68f9ab9eba8d6c30e74a74b862b2ef 100644
--- a/runtime/lib/stacktrace.cc
+++ b/runtime/lib/stacktrace.cc
@@ -16,11 +16,10 @@ namespace dart {
DECLARE_FLAG(bool, show_invisible_frames);
-static RawStackTrace* CurrentSyncStackTrace(Thread* thread) {
+static RawStackTrace* CurrentSyncStackTrace(Thread* thread,
+ intptr_t skip_frames = 1) {
Zone* zone = thread->zone();
const Function& null_function = Function::ZoneHandle(zone);
- // Skip the Dart exit frame.
- const intptr_t skip_frames = 1;
// Determine how big the stack trace is.
const intptr_t stack_trace_length =
@@ -49,7 +48,7 @@ static RawStackTrace* CurrentStackTrace(
bool causal_async_stacks = FLAG_causal_async_stacks) {
if (!causal_async_stacks) {
// Return the synchronous stack trace.
- return CurrentSyncStackTrace(thread);
+ return CurrentSyncStackTrace(thread, skip_frames);
}
Zone* zone = thread->zone();
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698