Fix missing top frame in exception stacks in product mode

runtime/lib/stacktrace.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/stacktrace.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/debugger.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object_store.h"
 #include "vm/runtime_entry.h"
 #include "vm/stack_frame.h"
 #include "vm/stack_trace.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, show_invisible_frames);
 
-static RawStackTrace* CurrentSyncStackTrace(Thread* thread) {
+static RawStackTrace* CurrentSyncStackTrace(Thread* thread,
+                                            intptr_t skip_frames = 1) {
   Zone* zone = thread->zone();
   const Function& null_function = Function::ZoneHandle(zone);
-  // Skip the Dart exit frame.
-  const intptr_t skip_frames = 1;
 
   // Determine how big the stack trace is.
   const intptr_t stack_trace_length =
       StackTraceUtils::CountFrames(thread, skip_frames, null_function);
 
   // Allocate once.
   const Array& code_array =
       Array::ZoneHandle(zone, Array::New(stack_trace_length));
   const Array& pc_offset_array =
       Array::ZoneHandle(zone, Array::New(stack_trace_length));
 
   // Collect the frames.
   const intptr_t collected_frames_count = StackTraceUtils::CollectFrames(
       thread, code_array, pc_offset_array, 0, stack_trace_length, skip_frames);
 
   ASSERT(collected_frames_count == stack_trace_length);
 
   return StackTrace::New(code_array, pc_offset_array);
 }
 
 
 static RawStackTrace* CurrentStackTrace(
     Thread* thread,
     bool for_async_function,
     intptr_t skip_frames = 1,
     bool causal_async_stacks = FLAG_causal_async_stacks) {
   if (!causal_async_stacks) {
     // Return the synchronous stack trace.
-    return CurrentSyncStackTrace(thread);
+    return CurrentSyncStackTrace(thread, skip_frames);
   }
 
   Zone* zone = thread->zone();
   Code& code = Code::ZoneHandle(zone);
   Smi& offset = Smi::ZoneHandle(zone);
   Function& async_function = Function::ZoneHandle(zone);
   StackTrace& async_stack_trace = StackTrace::ZoneHandle(zone);
   Array& async_code_array = Array::ZoneHandle(zone);
   Array& async_pc_offset_array = Array::ZoneHandle(zone);
 
@@ skipping 124 matching lines @@
 void _printCurrentStackTraceNoSafepoint() {
   StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
   StackFrame* frame = frames.NextFrame();
   while (frame != NULL) {
     OS::PrintErr("%s\n", frame->ToCString());
     frame = frames.NextFrame();
   }
 }
 
 }  // namespace dart