Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/predictors/resource_prefetcher_unittest.cc

Issue 2688633002: predictors: Add prefetching hit/miss histograms. (Closed)
Patch Set: Now with a test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetcher_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetcher_unittest.cc b/chrome/browser/predictors/resource_prefetcher_unittest.cc
index a412b552bcdab7ea207a15af92f6deee54fdc0f5..6f190d005d57cce686f3d87eb828ee0d470e63b4 100644
--- a/chrome/browser/predictors/resource_prefetcher_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetcher_unittest.cc
@@ -67,8 +67,9 @@ class TestResourcePrefetcherDelegate : public ResourcePrefetcher::Delegate {
return request_context_getter_->GetURLRequestContext();
}
- MOCK_METHOD1(ResourcePrefetcherFinished,
- void(ResourcePrefetcher* prefetcher));
+ MOCK_METHOD2(ResourcePrefetcherFinished,
+ void(ResourcePrefetcher* prefetcher,
+ const ResourcePrefetcher::PrefetcherStats&));
private:
scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
@@ -222,7 +223,7 @@ TEST_F(ResourcePrefetcherTest, TestPrefetcherFinishes) {
// Expect the final call.
EXPECT_CALL(prefetcher_delegate_,
- ResourcePrefetcherFinished(Eq(prefetcher_.get())));
+ ResourcePrefetcherFinished(Eq(prefetcher_.get()), testing::_));
OnResponse("http://yahoo.com/resource3.png");
CheckPrefetcherState(0, 0, 0);
@@ -266,7 +267,7 @@ TEST_F(ResourcePrefetcherTest, TestPrefetcherStopped) {
// Expect the final call.
EXPECT_CALL(prefetcher_delegate_,
- ResourcePrefetcherFinished(Eq(prefetcher_.get())));
+ ResourcePrefetcherFinished(Eq(prefetcher_.get()), testing::_));
OnResponse("http://m.google.com/resource1.jpg");
CheckPrefetcherState(0, 1, 0);
@@ -312,7 +313,7 @@ TEST_F(ResourcePrefetcherTest, TestHistogramsCollected) {
// Expect the final call.
EXPECT_CALL(prefetcher_delegate_,
- ResourcePrefetcherFinished(Eq(prefetcher_.get())));
+ ResourcePrefetcherFinished(Eq(prefetcher_.get()), testing::_));
OnResponse("http://www.google.com/resource6.png");
histogram_tester.ExpectTotalCount(

Powered by Google App Engine
This is Rietveld 408576698