Remove unnecessary repaint in SVGSVGElement::updateCurrentTranslate

Remove unnecessary repaint in SVGSVGElement::updateCurrentTranslate

This patch removes an unnecessary repaint of the dirty tree in
SVGSVGElement::updateCurrentTranslate.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173274

[rwlbuis, 2014-05-03 22:47:12]

On 2014/05/03 22:18:35, pdr wrote:

This seems like great find but why don't we need it anymore? I assume it was
needed in the past so what changed? Does the setNeedsLayout inform all ancestors
too maybe (I have not looked at that code in a while)?

[pdr., 2014-05-03 23:08:35]

On 2014/05/03 22:47:12, rwlbuis wrote:
> On 2014/05/03 22:18:35, pdr wrote:
> 
> This seems like great find but why don't we need it anymore? I assume it was
> needed in the past so what changed?

I don't think it makes sense to force a repaint of a tree that needs layout
since we know the repaint will be wrong. Repaint is now triggered after layout()
which will handle this case.

This code is probably just stale given our new repaint codepaths. The original
code was added in 2007 by someone named "Rob Buis" :)
https://bugs.webkit.org/show_bug.cgi?id=11272#c14

> Does the setNeedsLayout inform all ancestors
> too maybe (I have not looked at that code in a while)?

setNeedsLayout does indeed notify its containing block chain.

[rwlbuis, 2014-05-03 23:12:21]

On 2014/05/03 23:08:35, pdr wrote:
> On 2014/05/03 22:47:12, rwlbuis wrote:
> > On 2014/05/03 22:18:35, pdr wrote:
> > 
> > This seems like great find but why don't we need it anymore? I assume it was
> > needed in the past so what changed?
> 
> I don't think it makes sense to force a repaint of a tree that needs layout
> since we know the repaint will be wrong. Repaint is now triggered after
layout()
> which will handle this case.
> 
> This code is probably just stale given our new repaint codepaths. The original
> code was added in 2007 by someone named "Rob Buis" :)
> https://bugs.webkit.org/show_bug.cgi?id=11272#c14

Well I am sure things were different back then :-)

> > Does the setNeedsLayout inform all ancestors
> > too maybe (I have not looked at that code in a while)?
> 
> setNeedsLayout does indeed notify its containing block chain.

Good to know. As long as the bots show up green LGTM.

[pdr., 2014-05-03 23:13:58]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-05-03 23:14:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/268863005/1

[commit-bot: I haz the power, 2014-05-03 23:32:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-03 23:32:04]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink

[pdr., 2014-05-03 23:37:05]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-05-03 23:37:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/268863005/1

[commit-bot: I haz the power, 2014-05-04 04:48:34]

Change committed as 173274