Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 268863002: Revert 268019 "Add hpack_fuzz_wrapper to chromium_builder_asan." (Closed)

Created:
6 years, 7 months ago by Dan Beam
Modified:
6 years, 7 months ago
Reviewers:
Johnny
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268019 "Add hpack_fuzz_wrapper to chromium_builder_asan." Broke windows compile: FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_wrapper.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj /Fdobj\net\hpack_fuzz_wrapper.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_wrapper.cc(38) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath' No constructor could take the source type, or constructor overload resolution was ambiguous FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_example_generator.cc /Foobj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj /Fdobj\net\hpack_example_generator.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(51) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath' No constructor could take the source type, or constructor overload resolution was ambiguous c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(52) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &' c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(68) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(69) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_mutator.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj /Fdobj\net\hpack_fuzz_mutator.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(53) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath' No constructor could take the source type, or constructor overload resolution was ambiguous c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(56) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath' No constructor could take the source type, or constructor overload resolution was ambiguous c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(57) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &' c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(72) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(73) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data > Add hpack_fuzz_wrapper to chromium_builder_asan. > > BUG=353237 > > Review URL: https://codereview.chromium.org/266003005 TBR=jgraettinger@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -34 lines) Patch
M trunk/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/net.gyp View 2 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
6 years, 7 months ago (2014-05-03 03:15:03 UTC) #1
Dan Beam
6 years, 7 months ago (2014-05-03 03:15:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r268024 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698