Allow a unique origin to compare equal to itself

url/origin.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "url/origin.h"
 
 #include <stdint.h>
 #include <string.h>
 
 #include "base/logging.h"
@@ skipping 140 matching lines @@
 
   GURL tuple_url(tuple_.GetURL());
 
   if (!suborigin_.empty())
     return AddSuboriginToUrl(tuple_url, suborigin_);
 
   return tuple_url;
 }
 
 bool Origin::IsSameOriginWith(const Origin& other) const {
+  if (this == &other)
+    return true;
+
   if (unique_ || other.unique_)
     return false;
 
   return tuple_.Equals(other.tuple_) && suborigin_ == other.suborigin_;
 }
 
 bool Origin::IsSamePhysicalOriginWith(const Origin& other) const {

[Marijn Kruisselbrink, 2017/02/23 23:39:18]

Shouldn't an opaque origin also be considered same physical origin with itself?
I don't think this CL currently does that, as GetPhysicalOrigin() returns a copy
of the origin (so even if this == &other this->GetPhysicalOrigin() is not the
same as other.GetPhysicalOrigin())

   return GetPhysicalOrigin().IsSameOriginWith(other.GetPhysicalOrigin());
 }
 
 bool Origin::DomainIs(base::StringPiece lower_ascii_domain) const {
   return !unique_ && url::DomainIs(tuple_.host(), lower_ascii_domain);
 }
 
 bool Origin::operator<(const Origin& other) const {
   return tuple_ < other.tuple_;
 }
 
 std::ostream& operator<<(std::ostream& out, const url::Origin& origin) {
   return out << origin.Serialize();
 }
 
 bool IsSameOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSameOriginWith(Origin(b));
 }
 
 bool IsSamePhysicalOriginWith(const GURL& a, const GURL& b) {
   return Origin(a).IsSamePhysicalOriginWith(Origin(b));
 }
 
 }  // namespace url