[kernel] Rewrite method calls transformation

[kernel] Rewrite method calls transformation

Bring in old CL (https://chromereviews.googleplex.com/485307013/)

R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/0f711a9c54b288451c9bfda0d99c96724d0498da

[jensj, 2017-02-09 13:33:08]

jensj@google.com changed reviewers:
+ kustermann@google.com

[jensj, 2017-02-09 13:33:09]

Notes:
- Basically un-edited from old CL.
- New errors seems to have emerged: e.g. language/hello_dart_test gets an error:
```

Could not verify bootstrap classes : 'dart:convert/converter.dart': error:
signature type '(String, int) => List<int>' of function 'convert%2%' is not a
subtype of signature type '(dynamic, dynamic, dynamic) => T' of function
'convert%2%' where
00'dart:convert/ascii.dart': error: class '_UnicodeSubsetEncoder@8003594'
overrides method 'convert%2%' of super class or interface 'Converter' with
incompatible parameters
```

[kustermann, 2017-02-14 15:21:23]

lgtm

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/bin/transform.dart
File pkg/kernel/bin/transform.dart (right):

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/bin/transform.da...
pkg/kernel/bin/transform.dart:18: import
'package:kernel/transformations/empty.dart' as empty;
nit: sort?

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
File pkg/kernel/lib/transformations/method_call.dart (right):

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:12: import 'dart:math' as math;
nit: The core library imports go first with an empty line after it.

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:69: Set<String> stopNames = new
Set<String>.from(["call"]);
Maybe rename this to blacklistedSelectors

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:1308: V value;
final

[jensj, 2017-02-15 11:46:21]

So I wasn't there when this was apparently discussed (between Martin and Kevin?)
--- do you want me be land this despite it's errors?

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/bin/transform.dart
File pkg/kernel/bin/transform.dart (right):

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/bin/transform.da...
pkg/kernel/bin/transform.dart:18: import
'package:kernel/transformations/empty.dart' as empty;
On 2017/02/14 15:21:23, kustermann wrote:
> nit: sort?

Done.

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
File pkg/kernel/lib/transformations/method_call.dart (right):

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:12: import 'dart:math' as math;
On 2017/02/14 15:21:23, kustermann wrote:
> nit: The core library imports go first with an empty line after it.

Done.

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:69: Set<String> stopNames = new
Set<String>.from(["call"]);
On 2017/02/14 15:21:23, kustermann wrote:
> Maybe rename this to blacklistedSelectors

Done.

https://codereview.chromium.org/2688513004/diff/1/pkg/kernel/lib/transformati...
pkg/kernel/lib/transformations/method_call.dart:1308: V value;
On 2017/02/14 15:21:23, kustermann wrote:
> final

Done.

[jensj, 2017-02-15 13:18:40]

Description was changed from

==========
[kernel] Rewrite method calls transformation

Bring in old CL (https://chromereviews.googleplex.com/485307013/)
==========

to

==========
[kernel] Rewrite method calls transformation

Bring in old CL (https://chromereviews.googleplex.com/485307013/)

R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0f711a9c54b288451c9bfda0d99c96724d0498da
==========

[jensj, 2017-02-15 13:18:42]

Committed patchset #2 (id:20001) manually as
0f711a9c54b288451c9bfda0d99c96724d0498da (presubmit successful).