third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2688473005: Replace Document::postTask with WebTaskRunner::postTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2688473005: Replace Document::postTask with WebTaskRunner::postTask (Closed)

Patch Set: remove extra null-check: context on addConsoleMessage is now persistent Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 97bf482a6c9ff11ee298c762097a9b012dd0367e..9d4a06a0e3e624f5e7b8003546b9e02586468159 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -7,7 +7,6 @@

#include "core/HTMLNames.h"

#include "core/css/CSSFontSelector.h"

#include "core/dom/ElementTraversal.h"

-#include "core/dom/ExecutionContextTask.h"

#include "core/dom/NodeComputedStyle.h"

#include "core/dom/StyleEngine.h"

#include "core/dom/TaskRunnerHelper.h"

@@ -503,9 +502,9 @@ void PopupMenuImpl::updateFromElement(UpdateReason) {

if (m_needsUpdate)

return;

m_needsUpdate = true;

- ownerElement().document().postTask(

- TaskType::UserInteraction, BLINK_FROM_HERE,

- createSameThreadTask(&PopupMenuImpl::update, wrapPersistent(this)));

+ TaskRunnerHelper::get(TaskType::UserInteraction, &ownerElement().document())

+ ->postTask(BLINK_FROM_HERE,

+ WTF::bind(&PopupMenuImpl::update, wrapPersistent(this)));

}

void PopupMenuImpl::update() {

« no previous file with comments | « third_party/WebKit/Source/web/ExternalPopupMenu.cpp ('k') | no next file » | no next file with comments »