Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.h

Issue 2688463003: [chrome.cast.channel] Remove event logging. (Closed)
Patch Set: Remove errors object when socket is closed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_channel_api.h
diff --git a/extensions/browser/api/cast_channel/cast_channel_api.h b/extensions/browser/api/cast_channel/cast_channel_api.h
index b526e73e691e71dec22fda7bd2753b3acc4a1fc1..c257599da0abc997db1b5bd771a95346cc2bdf88 100644
--- a/extensions/browser/api/cast_channel/cast_channel_api.h
+++ b/extensions/browser/api/cast_channel/cast_channel_api.h
@@ -241,6 +241,7 @@ class CastChannelCloseFunction : public CastChannelAsyncApiFunction {
~CastChannelCloseFunction() override;
// AsyncApiFunction:
+ bool PrePrepare() override;
bool Prepare() override;
void AsyncWorkStart() override;
@@ -250,48 +251,9 @@ class CastChannelCloseFunction : public CastChannelAsyncApiFunction {
void OnClose(int result);
std::unique_ptr<cast_channel::Close::Params> params_;
-
- DISALLOW_COPY_AND_ASSIGN(CastChannelCloseFunction);
-};
-
-class CastChannelGetLogsFunction : public CastChannelAsyncApiFunction {
- public:
- CastChannelGetLogsFunction();
-
- protected:
- ~CastChannelGetLogsFunction() override;
-
- // AsyncApiFunction:
- bool PrePrepare() override;
- bool Prepare() override;
- void AsyncWorkStart() override;
-
- private:
- DECLARE_EXTENSION_FUNCTION("cast.channel.getLogs", CAST_CHANNEL_GETLOGS)
-
CastChannelAPI* api_;
- DISALLOW_COPY_AND_ASSIGN(CastChannelGetLogsFunction);
-};
-
-// TODO(eroman): crbug.com/601171: Delete this entire extension API. It
-// is currently deprecated and calling the function has no effect.
-class CastChannelSetAuthorityKeysFunction : public CastChannelAsyncApiFunction {
- public:
- CastChannelSetAuthorityKeysFunction();
-
- protected:
- ~CastChannelSetAuthorityKeysFunction() override;
-
- // AsyncApiFunction:
- bool Prepare() override;
- void AsyncWorkStart() override;
-
- private:
- DECLARE_EXTENSION_FUNCTION("cast.channel.setAuthorityKeys",
- CAST_CHANNEL_SETAUTHORITYKEYS)
-
- DISALLOW_COPY_AND_ASSIGN(CastChannelSetAuthorityKeysFunction);
+ DISALLOW_COPY_AND_ASSIGN(CastChannelCloseFunction);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698