Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: chrome/common/instant.mojom

Issue 2688453002: NTP: simplify mojo connection setup (Closed)
Patch Set: Merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/instant.mojom
diff --git a/chrome/common/instant.mojom b/chrome/common/instant.mojom
index a9f0fdd2043d81758ca1e3df73bd9f660eee7e44..287c846952e17417423ecd3180087c87aa7e8e23 100644
--- a/chrome/common/instant.mojom
+++ b/chrome/common/instant.mojom
@@ -17,6 +17,21 @@ enum OmniboxFocusState;
[Native]
enum NTPTileSource;
+// Interface used to connect to the embedded search interface. This is a
+// separate interface such that a reverse connection (|client| below) can be
+// passed when connecting.
+interface EmbeddedSearchConnector {
+ // Connect to the interface. |instant| is the connection which the client will
+ // use to query the embedded search interface. |client| is the connection used
+ // by the embedded search interface implementation to push browser state
+ // updates to the client.
+ Connect(associated Instant& instant, associated SearchBox client);
+};
+
+// TODO(tibell): Rename this to EmbeddedSearch.
+//
+// Browser interface to support embedded search. Render frames connect to this
+// interface to query browser data, such as the most visited pages.
interface Instant {
// Tells InstantExtended whether the embedded search API is supported.
// See http://dev.chromium.org/embeddedsearch
@@ -77,6 +92,10 @@ struct EmbeddedSearchRequestParams;
[Native]
struct ThemeBackgroundInfo;
+// TODO(tibell): Rename this to EmbeddedSearchClient.
+//
+// Renderer interface used by the browser to push updates to the client. For
+// example, the browser will tell the frame if the omnibox got focus.
interface SearchBox {
SetPageSequenceNumber(int32 page_seq_no);
@@ -96,6 +115,8 @@ interface SearchBox {
ThemeChanged(ThemeBackgroundInfo value);
+ // TODO(treib): Remove the *Result methods and instead add return values to
+ // the correspnding methods in the Instant interface above.
HistorySyncCheckResult(bool sync_history);
ChromeIdentityCheckResult(mojo.common.mojom.String16 identity,
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_unittest.cc ('k') | chrome/renderer/searchbox/searchbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698