NTP: simplify mojo connection setup

chrome/common/instant.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module chrome.mojom;
 
 import "mojo/common/string16.mojom";
 import "mojo/common/time.mojom";
 import "url/mojo/url.mojom";
 
 [Native]
 enum NTPLoggingEventType;
 
 [Native]
 enum OmniboxFocusState;
 
 [Native]
 enum NTPTileSource;
 
+// Interface used to connect to the new tab page (NTP) interface. This is a
+// separate interface such that a reverse connection (|search_box| below) can be
+// passed when connecting.

[dcheng, 2017/02/08 09:01:39]

Thanks for adding these comments. Mind describing the purpose of the
Instant/SearchBox interfaces as well? =)

[tibell, 2017/02/09 03:35:28]

I've added some more comments to express my current understanding.

+interface NTPConnector {

[Marc Treib, 2017/02/08 10:00:36]

Per my other comment: I don't think "NTP" is the right name here.
"EmbeddedSearchConnector"?

[tibell, 2017/02/09 03:35:28]

Done.

+  // Connect to the interface. |instant| is the connection which the client will
+  // use to query the NTP interface. |search_box| is the connection used by the
+  // NTP interface implementation to push browser state updates to the client.
+  Connect(associated Instant& instant, associated SearchBox search_box);
+};
+
+// TODO(tibell): Rename this to NTP.
 interface Instant {
   // Tells InstantExtended whether the embedded search API is supported.
   // See http://dev.chromium.org/embeddedsearch
   InstantSupportDetermined(int32 page_seq_no, bool result);
 
   // Tells InstantExtended to set the omnibox focus state.
   FocusOmnibox(int32 page_seq_no, OmniboxFocusState state);
 
   // TODO(treib): Remove the SearchBox prefix from these three methods.
   // Tells InstantExtended to delete a most visited item.
@@ skipping 65 matching lines @@
   Submit(mojo.common.mojom.String16 value,
          EmbeddedSearchRequestParams params);
 
   ThemeChanged(ThemeBackgroundInfo value);
 
   HistorySyncCheckResult(bool sync_history);
 
   ChromeIdentityCheckResult(mojo.common.mojom.String16 identity,
                             bool identity_match);
 };