chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index fa2d0fd961eabf48747647882883ed758cf2824f..9fb6e598f19cbb24146fa80151cea2bfcbd78e07 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -8314,6 +8314,9 @@ I don't think this site should be blocked!
           Protected content exceptions
         </message>
       </if>
+      <message name="IDS_PROTECTED_CONTENT_ENABLE_CHECKBOX" desc="The label of the checkbox for enabling protected content.">

[tommycli, 2017/02/08 01:35:05]

Hey... I have a few reservations about this:

We have both this new string (IDS_PROTECTED_CONTENT_ENABLE_CHECKBOX) and the old
string (IDS_PROTECTED_CONTENT_ENABLE)... which could be a bit confusing. xhwang
(over IM) said that in the long term, we should rename the old one to say
iDS_PROTECTED_CONTENT_ENABLE_UNIQUE_IDENTIFIERS.

How do the IDS tag names relate to the translations? If we change the IDS tag
names later, do we have to re-translate it? Put another way: if we commit a
subpar set of IDS tag names now, are we stuck with them?

I also want to get this into 57 also, but if there's last minute design changes
plus deadline pressure, I don't want to be on the path to bad code decisions.

If you deem necessary, feel free to land this patch anyways, and we can revisit
tomorrow.

[tommycli, 2017/02/08 01:37:40]

To be a bit more solution oriented: If we can re-name the IDS tags now to their
long-term best name, I won't have any reservations about this patch, and will
gladly stamp.

+        Allow sites to play protected content (recommended)
+      </message>
       <message name="IDS_PPAPI_BROKER_TAB_LABEL" desc="Label for PPAPI broker tab on Content Settings dialog">
         Unsandboxed plugin access
       </message>