chrome/browser/ui/cocoa/view_id_util_browsertest.mm - Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)

Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

index b935b4c5493b0487cb3d2df21f20b644bd3f9445..dd26af6d736064897720230077f8cf5a0c692594 100644

--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

@@ -52,7 +52,7 @@ class ViewIDTest : public InProcessBrowserTest {

DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);

// Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF

- browser()->window()->GetDownloadShelf()->Show();

+ browser()->window()->GetDownloadShelf()->Open();

// Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT

BookmarkModel* bookmark_model =