Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7732)

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Turn on animation for all tests except the one that was flaky due to animation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm b/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
index b68ba9589ae6dc66ea5d397ba25c3ce81c0d8c8e..d7a99e969ccc2a220b75715aff5728a05d37fd65 100644
--- a/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm
@@ -23,7 +23,8 @@
- (BOOL)isVisible;
- (void)showDownloadShelf:(BOOL)enable
- isUserAction:(BOOL)isUserAction;
+ isUserAction:(BOOL)isUserAction
+ animate:(BOOL)animate;
@end
@implementation FakeDownloadShelfController
@@ -34,7 +35,8 @@
}
- (void)showDownloadShelf:(BOOL)enable
- isUserAction:(BOOL)isUserAction {
+ isUserAction:(BOOL)isUserAction
+ animate:(BOOL)animate {
if (enable)
++callCountShow;
else
@@ -69,7 +71,7 @@ TEST_F(DownloadShelfMacTest, ForwardsShow) {
DownloadShelfMac shelf(browser(),
(DownloadShelfController*)shelf_controller_.get());
EXPECT_EQ(0, shelf_controller_.get()->callCountShow);
- shelf.Show();
+ shelf.Open();
EXPECT_EQ(1, shelf_controller_.get()->callCountShow);
}
« no previous file with comments | « chrome/browser/ui/cocoa/download/download_shelf_mac.mm ('k') | chrome/browser/ui/cocoa/view_id_util_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698