Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3180)

Unified Diff: chrome/browser/ui/exclusive_access/fullscreen_controller.cc

Issue 2688413012: Don't animate the download shelf when entering/exiting fullscreen. (Closed)
Patch Set: Try fixing a 10.9 test; ignore this patchset for the moment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/exclusive_access/fullscreen_controller.cc
diff --git a/chrome/browser/ui/exclusive_access/fullscreen_controller.cc b/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
index 04d2a6de8f66ede1e09f2b5728bdeeaab07a86f4..70ee7a5dcdf65958aae4fe3ae182b3df1f3b4351 100644
--- a/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
+++ b/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
@@ -238,6 +238,15 @@ void FullscreenController::OnTabClosing(WebContents* web_contents) {
ExclusiveAccessControllerBase::OnTabClosing(web_contents);
}
+void FullscreenController::WindowFullscreenStateWillChange() {
+ auto* exclusive_access_context = exclusive_access_manager()->context();
Nico 2017/02/17 15:53:46 nit: style guide says "only use auto if type obvio
Sidney San Martín 2017/02/17 16:07:08 Done.
+ if (exclusive_access_context->IsFullscreen()) {
+ exclusive_access_context->HideDownloadShelf();
+ } else {
+ exclusive_access_context->UnhideDownloadShelf();
+ }
+}
+
void FullscreenController::WindowFullscreenStateChanged() {
reentrant_window_state_change_call_check_ = true;
ExclusiveAccessContext* const exclusive_access_context =
@@ -249,9 +258,6 @@ void FullscreenController::WindowFullscreenStateChanged() {
toggled_into_fullscreen_ = false;
extension_caused_fullscreen_ = GURL();
NotifyTabExclusiveAccessLost();
- exclusive_access_context->UnhideDownloadShelf();
- } else {
- exclusive_access_context->HideDownloadShelf();
}
}

Powered by Google App Engine
This is Rietveld 408576698