Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: ui/display/screen_android.cc

Issue 2688413007: Add display::GetDisplayNearestView (Closed)
Patch Set: updated log Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/display/screen.h"
6
7 #include "base/logging.h"
8
9 namespace display {
10
11 // static
12 gfx::NativeWindow Screen::WindowForView(gfx::NativeView view) {
13 // Android cannot use implement this method here to convert |NativeView|
msw 2017/03/14 23:38:13 nit: "use implement" grammar, missing something?
Jinsuk Kim 2017/03/15 00:46:05 Done.
14 // to |NativeWindow| since it causes cyclic dependency.
15 // |GetDisplayNearestView| should be overriden directly.
16 NOTREACHED() << "|GetDisplayNearestView| on Android should not call "
17 "this method. Classes inheriting |Screen| should override "
18 "|GetDisplayNearestView| directly.";
19 return nullptr;
20 }
21
22 } // namespace display
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698