1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_GFX_VIEW_UTIL_H_
tapted
2017/02/15 00:36:10
view_util isn't a good name -- neither for the com
view_util isn't a good name -- neither for the component or the header (e.g.
sounds like it should be related to ui/views, but it's not at all. also
"foo_util.h" has a risk of becoming a grab-bag of unrelated things -- it's too
generic).
I think this is most related to ui/gfx/native_widget_types.h
so I suggest calling this header
- ui/gfx/native_widget/native_widget_properties.h or
- ui/native_widget/native_widget_properties.h or
- ui/display/native_widget_properties.h
oshima@ may have an opinion here (I don't have OWNERS powers around here :)
Jinsuk Kim
2017/02/16 10:11:25
Point taken. Tentatively chose the first one. Will
On 2017/02/15 00:36:10, tapted wrote:
> view_util isn't a good name -- neither for the component or the header (e.g.
> sounds like it should be related to ui/views, but it's not at all. also
> "foo_util.h" has a risk of becoming a grab-bag of unrelated things -- it's too
> generic).
>
> I think this is most related to ui/gfx/native_widget_types.h
>
> so I suggest calling this header
> - ui/gfx/native_widget/native_widget_properties.h or
> - ui/native_widget/native_widget_properties.h or
> - ui/display/native_widget_properties.h
>
> oshima@ may have an opinion here (I don't have OWNERS powers around here :)
Point taken. Tentatively chose the first one. Will wait for oshima@'s input too.
6 #define UI_GFX_VIEW_UTIL_H_
7
8 #include "ui/gfx/gfx_export.h"
9 #include "ui/gfx/native_widget_types.h"
10
11 namespace gfx {
12
13 // Get the top level window for the native view. This can return NULL.
Issue 2688413007: Add display::GetDisplayNearestView
(Closed)
Created 3 years, 10 months ago by Jinsuk Kim
Modified 3 years, 9 months ago
Reviewers: oshima, boliu, tapted, benwells, sky, msw, halliwell, bshe, alex clarke (OOO till 29th)
Base URL:
Comments: 60