Add display::GetDisplayNearestView

content/browser/renderer_host/render_widget_host_view_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base_observer.h"
 #include "content/browser/renderer_host/render_widget_host_view_frame_subscriber.h"
 #include "content/browser/renderer_host/text_input_manager.h"
 #include "content/common/content_switches_internal.h"
+#include "ui/base/layout.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/gfx/geometry/point_conversions.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/gfx/geometry/size_f.h"
+#include "ui/gfx/view_util.h"
 
 namespace content {
 
 namespace {
 
 // How many microseconds apart input events should be flushed.
 const int kFlushInputRateInUs = 16666;
 
 }
 
@@ skipping 63 matching lines @@
 void RenderWidgetHostViewBase::SetBackgroundColorToDefault() {
   SetBackgroundColor(SK_ColorWHITE);
 }
 
 bool RenderWidgetHostViewBase::GetBackgroundOpaque() {
   return SkColorGetA(background_color_) == SK_AlphaOPAQUE;
 }
 
 gfx::Size RenderWidgetHostViewBase::GetPhysicalBackingSize() const {
   display::Display display =
-      display::Screen::GetScreen()->GetDisplayNearestWindow(GetNativeView());
+      display::Screen::GetScreen()->GetDisplayNearestWindow(
+          gfx::GetTopLevel(GetNativeView()));
+
   return gfx::ScaleToCeiledSize(GetRequestedRendererSize(),
                                 display.device_scale_factor());
 }
 
 bool RenderWidgetHostViewBase::DoBrowserControlsShrinkBlinkSize() const {
   return false;
 }
 
 float RenderWidgetHostViewBase::GetTopControlsHeight() const {
   return 0.f;
@@ skipping 138 matching lines @@
 
   if (impl && impl->delegate())
     impl->delegate()->SendScreenRects();
 
   if (HasDisplayPropertyChanged(view) && impl)
     impl->NotifyScreenInfoChanged();
 }
 
 bool RenderWidgetHostViewBase::HasDisplayPropertyChanged(gfx::NativeView view) {
   display::Display display =
-      display::Screen::GetScreen()->GetDisplayNearestWindow(view);
+      display::Screen::GetScreen()->GetDisplayNearestWindow(
+          gfx::GetTopLevel(view));
   if (current_display_area_ == display.work_area() &&
       current_device_scale_factor_ == display.device_scale_factor() &&
       current_display_rotation_ == display.rotation()) {
     return false;
   }
 
   current_display_area_ = display.work_area();
   current_device_scale_factor_ = display.device_scale_factor();
   current_display_rotation_ = display.rotation();
   return true;
@@ skipping 27 matching lines @@
 void RenderWidgetHostViewBase::EndFrameSubscription() {
   NOTREACHED();
 }
 
 void RenderWidgetHostViewBase::FocusedNodeTouched(
     const gfx::Point& location_dips_screen,
     bool editable) {
   DVLOG(1) << "FocusedNodeTouched: " << editable;
 }
 
+float RenderWidgetHostViewBase::GetScaleFactorForNativeView() const {
+  return ui::GetScaleFactorForNativeWindow(gfx::GetTopLevel(GetNativeView()));

[tapted, 2017/02/15 00:36:10]

if callers still need the virtual method in RWHV, this should probably just be
return current_device_scale_factor_;   (content OWNERS might have other ideas
though)

That is, after stuff that has (or is) a RenderWidgetHostViewBase is using
current_device_scale_factor(), the remaining things outside of content wanting
GetScaleFactorForNativeView() can probably just go back to what they were doing
before. 

However, those methods are a LOT more expensive than just using
current_device_scale_factor_ .

For example, in ScreenMac::GetDisplayNearestWindow() has a comment

    // Note the following line calls -[NSWindow
    // _bestScreenBySpaceAssignmentOrGeometry] which is quite expensive and
    // performs IPC with the window server process.
    NSScreen* match_screen = [window screen];

it would be nice to avoid that.


i.e. my vote would be to use a content-public/exported virtual method on
RenderWidgetHostView that just returns current_device_scale_factor_ here.

But there's usually a resistance to adding new content-public methods. You'll
need a content OWNER for this.

[Jinsuk Kim, 2017/02/16 10:11:25]

Thanks for the suggestion. Done as suggested. I think the new method is useful
so I'm hoping its addition is justifiable.

+}
+
 uint32_t RenderWidgetHostViewBase::RendererFrameNumber() {
   return renderer_frame_number_;
 }
 
 void RenderWidgetHostViewBase::DidReceiveRendererFrame() {
   ++renderer_frame_number_;
 }
 
 void RenderWidgetHostViewBase::FlushInput() {
   RenderWidgetHostImpl* impl = NULL;
@@ skipping 177 matching lines @@
 
 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
   return false;
 }
 
 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
   return cc::SurfaceId();
 }
 
 }  // namespace content