Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2688413004: Add mode to test.dart to run dart2js with kernel, and include initial set of (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add mode to test.dart to run dart2js with kernel, and include initial set of failures in status files BUG= R=efortuna@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/91796be231428751eb017181b893878a75a254c4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update status files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+736 lines, -0 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 1 chunk +58 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 1 chunk +107 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +52 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +505 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
FYI - I need to update the .status files a bit (some Fail shoudl have ...
3 years, 10 months ago (2017-02-14 01:03:59 UTC) #2
Emily Fortuna
lgtm!
3 years, 10 months ago (2017-02-14 02:05:22 UTC) #3
Bill Hesse
LGTM https://codereview.chromium.org/2688413004/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status File tests/compiler/dart2js_extra/dart2js_extra.status (right): https://codereview.chromium.org/2688413004/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status#newcode128 tests/compiler/dart2js_extra/dart2js_extra.status:128: 21666_test: Fail # please triage You could file ...
3 years, 10 months ago (2017-02-14 05:27:46 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2688413004/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status File tests/compiler/dart2js_extra/dart2js_extra.status (right): https://codereview.chromium.org/2688413004/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status#newcode128 tests/compiler/dart2js_extra/dart2js_extra.status:128: 21666_test: Fail # please triage On 2017/02/14 05:27:46, Bill ...
3 years, 10 months ago (2017-02-14 22:12:48 UTC) #5
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-14 22:37:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
91796be231428751eb017181b893878a75a254c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698