chrome/android/java/res/layout/new_tab_page_snippets_card.xml - Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions. (Closed)

Patch Set: rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

index 650429e5e2020358196fee959ea4ed70fe629a73..eb2f52d8fa2c8604500ca76c6ba4f0a2e17a4d6e 100644

--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

@@ -84,14 +84,14 @@

</LinearLayout>

- <ImageView

+ <org.chromium.chrome.browser.widget.TintedImageView

android:id="@+id/article_thumbnail"

android:layout_width="@dimen/snippets_thumbnail_size"

android:layout_height="@dimen/snippets_thumbnail_size"

android:layout_alignParentTop="true"

android:layout_alignParentEnd="true"

android:layout_marginStart="16dp"

- android:scaleType="centerCrop"

+ android:scaleType="center"

Michael van Ouwerkerk 2017/02/14 13:35:31 Does this change also affect regular article thumb

vitaliii 2017/02/14 16:09:30 Done. Good observation! Now I set different scale

android:contentDescription="@null"

android:src="@null" />

</RelativeLayout>