chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java - Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions. (Closed)

Patch Set: clean rebase + dfalcantara@ comment + isRecycled() check in DownloadItemView Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | chrome/browser/ntp_snippets/download_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

index 2295647d37f88cd08bd3238031a7f5d1e6e99ed8..69691489464e1e9188917ce3415ddf09f5965e91 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

@@ -93,7 +93,7 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD

public void openSnippet(int windowOpenDisposition, SnippetArticle article) {

NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);

- if (article.mIsAssetDownload) {

+ if (article.isAssetDownload()) {

assert windowOpenDisposition == WindowOpenDisposition.CURRENT_TAB

|| windowOpenDisposition == WindowOpenDisposition.NEW_WINDOW

|| windowOpenDisposition == WindowOpenDisposition.NEW_FOREGROUND_TAB;

@@ -119,7 +119,7 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD

// We explicitly open an offline page only for offline page downloads. For all other

// sections the URL is opened and it is up to Offline Pages whether to open its offline

// page (e.g. when offline).

- if (article.isDownload() && !article.mIsAssetDownload) {

+ if (article.isDownload() && !article.isAssetDownload()) {

assert article.getOfflinePageOfflineId() != null;

assert windowOpenDisposition == WindowOpenDisposition.CURRENT_TAB

|| windowOpenDisposition == WindowOpenDisposition.NEW_WINDOW