chrome/android/java/res/layout/new_tab_page_snippets_card.xml - Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2688383005: [NTP::Downloads] Show thumbnails for Download suggestions. (Closed)

Patch Set: clean rebase + dfalcantara@ comment + isRecycled() check in DownloadItemView Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <RelativeLayout	6 <RelativeLayout

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 xmlns:chrome="http://schemas.android.com/apk/res-auto"	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

9 xmlns:tools="http://schemas.android.com/tools"	9 xmlns:tools="http://schemas.android.com/tools"

10 android:id="@+id/snippets_card_view"	10 android:id="@+id/snippets_card_view"

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 android:layout_height="@dimen/snippets_offline_icon_size"	77 android:layout_height="@dimen/snippets_offline_icon_size"

78 android:layout_marginStart="6dp"	78 android:layout_marginStart="6dp"

79 android:alpha="0.54"	79 android:alpha="0.54"

80 android:src="@drawable/offline_pin_round"	80 android:src="@drawable/offline_pin_round"

81 android:contentDescription="@string/accessibility_ntp_offline_badge"	81 android:contentDescription="@string/accessibility_ntp_offline_badge"

82 android:visibility="gone"	82 android:visibility="gone"

83 chrome:tint="#000" />	83 chrome:tint="#000" />

84	84

85 </LinearLayout>	85 </LinearLayout>

86	86

87 <ImageView	87 <org.chromium.chrome.browser.widget.TintedImageView

88 android:id="@+id/article_thumbnail"	88 android:id="@+id/article_thumbnail"

89 android:layout_width="@dimen/snippets_thumbnail_size"	89 android:layout_width="@dimen/snippets_thumbnail_size"

90 android:layout_height="@dimen/snippets_thumbnail_size"	90 android:layout_height="@dimen/snippets_thumbnail_size"

91 android:layout_alignParentTop="true"	91 android:layout_alignParentTop="true"

92 android:layout_alignParentEnd="true"	92 android:layout_alignParentEnd="true"

93 android:layout_marginStart="16dp"	93 android:layout_marginStart="16dp"

94 android:scaleType="centerCrop"	94 android:scaleType="centerCrop"

95 android:contentDescription="@null"	95 android:contentDescription="@null"

96 android:src="@null" />	96 android:src="@null" />

97 </RelativeLayout>	97 </RelativeLayout>

OLD	NEW