content/renderer/screen_orientation/screen_orientation_dispatcher.h - Issue 2688383002: [ScreenOrientation] Merge mojo interface ScreenOrientationListener into ScreenOrientation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.h

Issue 2688383002: [ScreenOrientation] Merge mojo interface ScreenOrientationListener into ScreenOrientation

Patch Set: Address comments from mlamouri@ Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/renderer_blink_platform_impl.cc ('k') | content/renderer/screen_orientation/screen_orientation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.h

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.h b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

index ab5994e48e3aa81c8b32a41e0d8e149b4ddd7923..20102b94e7935d499004be8769ba547da0814bca 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.h

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

@@ -47,6 +47,8 @@ class CONTENT_EXPORT ScreenOrientationDispatcher :

blink::WebScreenOrientationLockType orientation,

std::unique_ptr<blink::WebLockOrientationCallback> callback) override;

void unlockOrientation() override;

+ void startAccurateListen() override;

+ void stopAccurateListen() override;

void OnLockOrientationResult(int request_id,

ScreenOrientationLockResult result);

@@ -55,7 +57,7 @@ class CONTENT_EXPORT ScreenOrientationDispatcher :

int GetRequestIdForTests();

- void EnsureScreenOrientationService();

+ device::mojom::ScreenOrientation* GetRemoteScreenOrientation();

// This should only be called by ScreenOrientationDispatcherTest

void SetScreenOrientationForTests(