Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2624)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/mus/accelerators/accelerator_controller_unittest.cc

Issue 2688353005: Fix shelf alignment and auto-hide initialization. (Closed)
Patch Set: Fix mash_unittests by installing a TestShellDelegate. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/test/test_shelf_delegate.cc ('k') | ash/mus/shell_delegate_mus.h » ('j') | ash/mus/window_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/accelerators/accelerator_controller_unittest.cc
diff --git a/ash/mus/accelerators/accelerator_controller_unittest.cc b/ash/mus/accelerators/accelerator_controller_unittest.cc
index e9999705eccb49b8b1833c9eefa0c0ed70fce765..8366f06b2627aec693723b6cfde94e2997cfddb8 100644
--- a/ash/mus/accelerators/accelerator_controller_unittest.cc
+++ b/ash/mus/accelerators/accelerator_controller_unittest.cc
@@ -952,9 +952,7 @@ TEST_F(AcceleratorControllerTest, GlobalAccelerators) {
ProcessInController(ui::Accelerator(ui::VKEY_T, ui::EF_CONTROL_DOWN)));
// New incognito window
- // TODO(sky): this should be true but fails because WmTestBase is not using
- // TestShellDelegate: http://crbug.com/632211.
- EXPECT_FALSE(ProcessInController(
+ EXPECT_TRUE(ProcessInController(
ui::Accelerator(ui::VKEY_N, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
// New window
« no previous file with comments | « ash/common/test/test_shelf_delegate.cc ('k') | ash/mus/shell_delegate_mus.h » ('j') | ash/mus/window_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698