Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: ash/mus/window_manager.h

Issue 2688353005: Fix shelf alignment and auto-hide initialization. (Closed)
Patch Set: Fix mash_unittests by installing a TestShellDelegate. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/mus/test/wm_test_helper.cc ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_MUS_WINDOW_MANAGER_H_ 5 #ifndef ASH_MUS_WINDOW_MANAGER_H_
6 #define ASH_MUS_WINDOW_MANAGER_H_ 6 #define ASH_MUS_WINDOW_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 25 matching lines...) Expand all
36 } 36 }
37 37
38 namespace wm { 38 namespace wm {
39 class WMState; 39 class WMState;
40 } 40 }
41 41
42 namespace ash { 42 namespace ash {
43 43
44 class RootWindowController; 44 class RootWindowController;
45 class ScreenMus; 45 class ScreenMus;
46 class SystemTrayDelegate; 46 class ShellDelegate;
47 47
48 namespace mus { 48 namespace mus {
49 49
50 class AcceleratorHandler; 50 class AcceleratorHandler;
51 class ShadowController; 51 class ShadowController;
52 class WmLookupMus; 52 class WmLookupMus;
53 class WmTestHelper; 53 class WmTestHelper;
54 54
55 // WindowManager serves as the WindowManagerDelegate and 55 // WindowManager serves as the WindowManagerDelegate and
56 // WindowTreeClientDelegate for mash. WindowManager creates (and owns) 56 // WindowTreeClientDelegate for mash. WindowManager creates (and owns)
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 187
188 bool created_shell_ = false; 188 bool created_shell_ = false;
189 189
190 std::unique_ptr<WmLookupMus> lookup_; 190 std::unique_ptr<WmLookupMus> lookup_;
191 191
192 std::map<uint16_t, AcceleratorHandler*> accelerator_handlers_; 192 std::map<uint16_t, AcceleratorHandler*> accelerator_handlers_;
193 uint16_t next_accelerator_namespace_id_ = 0u; 193 uint16_t next_accelerator_namespace_id_ = 0u;
194 194
195 scoped_refptr<base::SequencedWorkerPool> blocking_pool_; 195 scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
196 196
197 // If non-null this is used as the return value from 197 // Only set in tests. If non-null this is used as the shell delegate.
198 // ShellDelegateMus::CreateSystemTrayDelegate(). This is only set in tests. 198 std::unique_ptr<ShellDelegate> shell_delegate_for_test_;
James Cook 2017/02/14 15:12:07 Woo hoo, thanks for doing this!
msw 2017/02/14 16:26:18 You're welcome :)
199 //
200 // TODO(jamescook): Pass a TestShellDelegate into WindowManager and use it to
201 // create the various test delegates rather than a member.
202 std::unique_ptr<SystemTrayDelegate> system_tray_delegate_for_test_;
203 199
204 DISALLOW_COPY_AND_ASSIGN(WindowManager); 200 DISALLOW_COPY_AND_ASSIGN(WindowManager);
205 }; 201 };
206 202
207 } // namespace mus 203 } // namespace mus
208 } // namespace ash 204 } // namespace ash
209 205
210 #endif // ASH_MUS_WINDOW_MANAGER_H_ 206 #endif // ASH_MUS_WINDOW_MANAGER_H_
OLDNEW
« no previous file with comments | « ash/mus/test/wm_test_helper.cc ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698