Fix shelf alignment and auto-hide initialization.

ash/common/test/test_shelf_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/test/test_shelf_delegate.h"
 
 #include <utility>
 
 #include "ash/common/shelf/shelf_model.h"
+#include "ash/common/shelf/wm_shelf.h"
+#include "ash/common/shell_observer.h"
 #include "ash/common/test/test_shelf_item_delegate.h"
+#include "ash/common/wm_shell.h"
 #include "ash/common/wm_window.h"
 #include "ash/common/wm_window_property.h"
+#include "ash/root_window_controller.h"
 #include "base/memory/ptr_util.h"
 
 namespace ash {
 namespace test {
 
 TestShelfDelegate* TestShelfDelegate::instance_ = nullptr;
 
-TestShelfDelegate::TestShelfDelegate(ShelfModel* model) : model_(model) {
+// A ShellObserver that sets the shelf alignment and auto hide behavior when the
+// shelf is created, to simulate ChromeLauncherController's behavior.
+class ShelfInitializer : public ShellObserver {
+ public:
+  ShelfInitializer() { WmShell::Get()->AddShellObserver(this); }
+  ~ShelfInitializer() override { WmShell::Get()->RemoveShellObserver(this); }
+
+  // ShellObserver:
+  void OnShelfCreatedForRootWindow(WmWindow* root_window) override {
+    WmShelf* shelf = root_window->GetRootWindowController()->GetShelf();
+    // Do not override the custom initialization performed by some unit tests.
+    if (shelf->alignment() == SHELF_ALIGNMENT_BOTTOM_LOCKED &&
+        shelf->auto_hide_behavior() == SHELF_AUTO_HIDE_ALWAYS_HIDDEN) {
+      shelf->SetAlignment(SHELF_ALIGNMENT_BOTTOM);
+      shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
+      shelf->UpdateVisibilityState();
+    }
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ShelfInitializer);
+};
+
+TestShelfDelegate::TestShelfDelegate()
+    : shelf_initializer_(base::MakeUnique<ShelfInitializer>()) {
   CHECK(!instance_);
   instance_ = this;
 }
 
 TestShelfDelegate::~TestShelfDelegate() {
   instance_ = nullptr;
 }
 
 void TestShelfDelegate::AddShelfItem(WmWindow* window) {
   AddShelfItem(window, STATUS_CLOSED);
 }
 
 void TestShelfDelegate::AddShelfItem(WmWindow* window,
                                      const std::string& app_id) {
   AddShelfItem(window, STATUS_CLOSED);
   ShelfID shelf_id = window->GetIntProperty(WmWindowProperty::SHELF_ID);
   AddShelfIDToAppIDMapping(shelf_id, app_id);
 }
 
 void TestShelfDelegate::AddShelfItem(WmWindow* window, ShelfItemStatus status) {
   ShelfItem item;
   if (window->GetType() == ui::wm::WINDOW_TYPE_PANEL)
     item.type = TYPE_APP_PANEL;
   else
     item.type = TYPE_APP;
-  ShelfID id = model_->next_id();
+  ShelfModel* model = WmShell::Get()->shelf_model();
+  ShelfID id = model->next_id();
   item.status = status;
-  model_->Add(item);
+  model->Add(item);
   window->AddObserver(this);
 
-  model_->SetShelfItemDelegate(id,
-                               base::MakeUnique<TestShelfItemDelegate>(window));
+  model->SetShelfItemDelegate(id,
+                              base::MakeUnique<TestShelfItemDelegate>(window));
   window->SetIntProperty(WmWindowProperty::SHELF_ID, id);
 }
 
 void TestShelfDelegate::RemoveShelfItemForWindow(WmWindow* window) {
   ShelfID shelf_id = window->GetIntProperty(WmWindowProperty::SHELF_ID);
   if (shelf_id == 0)
     return;
-  int index = model_->ItemIndexByID(shelf_id);
+  ShelfModel* model = WmShell::Get()->shelf_model();
+  int index = model->ItemIndexByID(shelf_id);
   DCHECK_NE(-1, index);
-  model_->RemoveItemAt(index);
+  model->RemoveItemAt(index);
   window->RemoveObserver(this);
   if (HasShelfIDToAppIDMapping(shelf_id)) {
     const std::string& app_id = GetAppIDForShelfID(shelf_id);
     if (IsAppPinned(app_id))
       UnpinAppWithID(app_id);
     if (HasShelfIDToAppIDMapping(shelf_id))
       RemoveShelfIDToAppIDMapping(shelf_id);
   }
 }
 
@@ skipping 49 matching lines @@
                                                  const std::string& app_id) {
   shelf_id_to_app_id_map_[shelf_id] = app_id;
 }
 
 void TestShelfDelegate::RemoveShelfIDToAppIDMapping(ShelfID shelf_id) {
   shelf_id_to_app_id_map_.erase(shelf_id);
 }
 
 }  // namespace test
 }  // namespace ash