third_party/WebKit/Source/core/svg/SVGGElement.cpp - Issue 2688343002: Unify SVG parent checks for LayoutObject construction using always the light tree parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGGElement.cpp

Issue 2688343002: Unify SVG parent checks for LayoutObject construction using always the light tree parent. (Closed)

Patch Set: Unify SVG parent checks for LayoutObject construction using always the light tree parent. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGGElement.cpp b/third_party/WebKit/Source/core/svg/SVGGElement.cpp

index 3198284ca099b9109146d58db4c00fe05b9b0d7c..1d5541a8c72008b31a06d6dc792632bc0d45ca21 100644

--- a/third_party/WebKit/Source/core/svg/SVGGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGGElement.cpp

@@ -48,8 +48,7 @@ bool SVGGElement::layoutObjectIsNeeded(const ComputedStyle&) {

// Unlike SVGElement::layoutObjectIsNeeded(), we still create layoutObjects,

// even if display is set to 'none' - which is special to SVG <g> container

// elements.

- return parentOrShadowHostElement() &&

- parentOrShadowHostElement()->isSVGElement() && isValid();

+ return isValid() && hasSVGParent();

}

} // namespace blink