Issue 268833009: Disable 'clang_use_chrome_plugins' on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268833009: Disable 'clang_use_chrome_plugins' on Windows (Closed)

Created:
6 years, 7 months ago by hans

Modified:
6 years, 7 months ago

Reviewers:
Reid Kleckner, zerny-chromium, Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disable 'clang_use_chrome_plugins' on Windows Clang plugins don't work on Windows currently, and when Blink r173367 enabled the Oilpan GC plugin by default, it broke all the Win Clang FYI builders. This should fix that. BUG=82385 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268600

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/268833009/1

6 years, 7 months ago (2014-05-06 20:11:15 UTC) #4

Message was sent while issue was closed.

Thanks! LGTM

Expand Messages | Collapse Messages