Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3939)

Unified Diff: chrome/browser/about_flags.cc

Issue 2688303002: Add a feature flag for the new Windows USB backend. (Closed)
Patch Set: Fix Android build. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | device/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index cb67503464991ba1d17769987acbcf269bef317a..f2ae7efcbd6394b1f175d44f007f1c76375761bc 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -71,6 +71,7 @@
#include "content/public/common/content_switches.h"
#include "content/public/common/feature_h264_with_openh264_ffmpeg.h"
#include "content/public/common/features.h"
+#include "device/base/features.h"
#include "extensions/features/features.h"
#include "gin/public/gin_features.h"
#include "media/audio/audio_features.h"
@@ -2208,7 +2209,13 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-midi-manager-dynamic-instantiation",
IDS_FLAGS_ENABLE_MIDI_MANAGER_DYNAMIC_INSTANTIATION_NAME,
IDS_FLAGS_ENABLE_MIDI_MANAGER_DYNAMIC_INSTANTIATION_DESCRIPTION, kOsAll,
- FEATURE_VALUE_TYPE(midi::features::kMidiManagerDynamicInstantiation)}
+ FEATURE_VALUE_TYPE(midi::features::kMidiManagerDynamicInstantiation)},
+
+#if defined(OS_WIN)
scheib 2017/02/11 01:45:18 Are these #if defined required? IIRC the logic of
Reilly Grant (use Gerrit) 2017/02/11 01:48:55 The base::Feature instance is defined within #if g
+ {"new-usb-backend", IDS_FLAGS_NEW_USB_BACKEND_NAME,
+ IDS_FLAGS_NEW_USB_BACKEND_DESCRIPTION, kOsWin,
+ FEATURE_VALUE_TYPE(device::kNewUsbBackend)},
+#endif // defined(OS_WIN)
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | device/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698