Get rid of custom bindings for AudioBufferSourceNode.buffer setter

Source/modules/webaudio/AudioBufferSourceNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #if ENABLE(WEB_AUDIO)
 
 #include "modules/webaudio/AudioBufferSourceNode.h"
 
+#include "bindings/v8/ExceptionState.h"
 #include "core/page/PageConsole.h"
 #include "platform/audio/AudioUtilities.h"
 #include "modules/webaudio/AudioContext.h"
 #include "modules/webaudio/AudioNodeOutput.h"
 #include "platform/FloatConversion.h"
 #include "wtf/MainThread.h"
 #include "wtf/MathExtras.h"
 #include <algorithm>
 
 using namespace std;
@@ skipping 287 matching lines @@
     return true;
 }
 
 
 void AudioBufferSourceNode::reset()
 {
     m_virtualReadIndex = 0;
     m_lastGain = gain()->value();
 }
 
-bool AudioBufferSourceNode::setBuffer(AudioBuffer* buffer)
+void AudioBufferSourceNode::setBuffer(AudioBuffer* buffer, ExceptionState& es)
 {
     ASSERT(isMainThread());
+    // FIXME: It does not look like we should throw if the buffer is null as
+    // the attribute is nullable in the specification.
+    if (!buffer) {
+        es.throwTypeError("buffer cannot be null");
+        return;
+    }
 
     // The context must be locked since changing the buffer can re-configure the number of channels that are output.
     AudioContext::AutoLocker contextLocker(context());
 
     // This synchronizes with process().
     MutexLocker processLocker(m_processLock);
 
     if (buffer) {
         // Do any necesssary re-configuration to the buffer's number of channels.
         unsigned numberOfChannels = buffer->numberOfChannels();
 
-        if (numberOfChannels > AudioContext::maxNumberOfChannels())
-            return false;
+        if (numberOfChannels > AudioContext::maxNumberOfChannels()) {
+            es.throwTypeError("AudioBuffer unsupported number of channels");

[Raymond Toy (Google), 2013/10/10 22:40:57]

Should this be a DOMException?  And if so, can we have a more informative
message like what was done in https://codereview.chromium.org/24877002/?

+            return;
+        }
 
         output(0)->setNumberOfChannels(numberOfChannels);
 
         m_sourceChannels = adoptArrayPtr(new const float* [numberOfChannels]);
         m_destinationChannels = adoptArrayPtr(new float* [numberOfChannels]);
 
         for (unsigned i = 0; i < numberOfChannels; ++i)
             m_sourceChannels[i] = buffer->getChannelData(i)->data();
     }
 
     m_virtualReadIndex = 0;
     m_buffer = buffer;
-
-    return true;
 }
 
 unsigned AudioBufferSourceNode::numberOfChannels()
 {
     return output(0)->numberOfChannels();
 }
 
 void AudioBufferSourceNode::startGrain(double when, double grainOffset)
 {
     // Duration of 0 has special value, meaning calculate based on the entire buffer's duration.
@@ skipping 101 matching lines @@
 void AudioBufferSourceNode::finish()
 {
     clearPannerNode();
     ASSERT(!m_pannerNode);
     AudioScheduledSourceNode::finish();
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)