Suppress a few analysis warnings in the analyzer codebase.

Suppress a few analysis warnings in the analyzer codebase.

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0fee4146729098ebd88f21337677e73a309f9497

[devoncarew, 2017-02-10 21:03:23]

devoncarew@google.com changed reviewers:
+ scheglov@google.com

[devoncarew, 2017-02-10 21:03:24]

Suppress a few analysis warnings in the analyzer codebase. This is for
deprecated API usage and a few unused symbol warnings.

[scheglov, 2017-02-10 21:06:53]

https://codereview.chromium.org/2688253002/diff/1/pkg/analysis_server/test/st...
File pkg/analysis_server/test/stress/utilities/server.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/utilities/server.dart:446:
//_analysisRootExcludes = excluded;
Remove it.

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:28: import
'package:analyzer/src/generated/sdk_io.dart'; // ignore: deprecated_member_use
I think we might want to keep these warnings to nag us so that we removed these
deprecated libraries at last.

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:66: ByteStore _byteStore; // ignore:
unused_field
I think Brian will use it eventually, and again, I think it's OK to keep it
visible so that we don't hide and forget about it.

[devoncarew, 2017-02-10 21:12:35]

https://codereview.chromium.org/2688253002/diff/1/pkg/analysis_server/test/st...
File pkg/analysis_server/test/stress/utilities/server.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/utilities/server.dart:446:
//_analysisRootExcludes = excluded;
On 2017/02/10 21:06:53, scheglov wrote:
> Remove it.

Done.

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:28: import
'package:analyzer/src/generated/sdk_io.dart'; // ignore: deprecated_member_use
On 2017/02/10 21:06:53, scheglov wrote:
> I think we might want to keep these warnings to nag us so that we removed
these
> deprecated libraries at last.

OK, removed the ignore.

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2688253002/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:66: ByteStore _byteStore; // ignore:
unused_field
On 2017/02/10 21:06:53, scheglov wrote:
> I think Brian will use it eventually, and again, I think it's OK to keep it
> visible so that we don't hide and forget about it.

Removed the ignore.

[scheglov, 2017-02-10 21:13:12]

LGTM

[devoncarew, 2017-02-10 21:16:32]

Description was changed from

==========
Suppress a few analysis warnings in the analyzer codebase.

BUG=
==========

to

==========
Suppress a few analysis warnings in the analyzer codebase.

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0fee4146729098ebd88f21337677e73a309f9497
==========

[devoncarew, 2017-02-10 21:16:34]

Committed patchset #2 (id:20001) manually as
0fee4146729098ebd88f21337677e73a309f9497 (presubmit successful).

[Brian Wilkerson, 2017-02-11 22:27:36]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-11 22:27:36]

https://codereview.chromium.org/2688253002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/stress/utilities/server.dart (right):

https://codereview.chromium.org/2688253002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/stress/utilities/server.dart:443: List<String>
included, List<String> excluded,
Sigh. I was planning on using the excludes information too, as soon as I could
get back to finishing the stress test. But if you're going to remove the field,
then you might as well remove the parameter too.

[devoncarew, 2017-02-12 02:36:20]

It's easy enough to revert. Loading up the codebase in IntelliJ, I saw only a
few warnings for the entire codebase, so thought it would be nice to make a
clean sweep.