Mojo framework for AndroidOverlay.

content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java

Index: content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java b/content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java
new file mode 100644
index 0000000000000000000000000000000000000000..e9fd257c0c720d3cdfc1666e096089881ee138ec
--- /dev/null
+++ b/content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java
@@ -0,0 +1,49 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.content.browser.androidoverlay;
+
+import android.content.Context;
+
+import org.chromium.media.mojom.AndroidOverlayClient;
+import org.chromium.media.mojom.AndroidOverlayConfig;
+import org.chromium.media.mojom.AndroidOverlayProvider;
+import org.chromium.mojo.system.MojoException;
+import org.chromium.services.service_manager.InterfaceFactory;
+
+/**
+ * Default impl of AndroidOverlayProvider.  Creates AndroidOverlayImpls.
+ */
+public class AndroidOverlayProviderImpl implements AndroidOverlayProvider {
+    private static final String TAG = "AndroidOverlayProvider";
+
+    /**
+     * Create an overlay matching |config| and send it to |client|.  Remember that potentially many
+     * providers are created.
+     */
+    public void createOverlay(AndroidOverlayClient client, AndroidOverlayConfig config) {

[dcheng, 2017/02/28 05:22:03]

Normally, it's best to implement the interface in the same CL as the one that
adds the interface methods, to make it easier to security review things
end-to-end. This is the preferred option, so if that's possible here, that would
be best.

If that's not possible, can you make sure to include an IPC reviewer on the
followup CL that implements this.

[liberato (no reviews please), 2017/03/06 07:51:04]

i'll pick option 2.  :)

the reason is that this is a rewrite of
https://codereview.chromium.org/2178973004/ to us mojo, since boliu@ correctly
pointed out that it's more chrom-y than binder.  much of the remaining bits
there will be more or less identical to what will be added in later CLs to the
mojo-based overlay framework.

however, that CL was also unreasonably large in my opinion, so i'd really,
really like to keep this one simpler.  after abandoning a ~6 month CL, i'm all
about incremental progress right now.  :)

+        // We could also call |client.onInitialized| to succeed for example:
+        // AndroidOverlayImpl overlay = new AndroidOverlayImpl(client, config);
+        // client.onInitialized(overlay);
+        client.onDestroyed();
+    }
+
+    @Override
+    public void close() {}
+
+    @Override
+    public void onConnectionError(MojoException e) {}
+
+    /**
+     * Mojo factory.
+     */
+    public static class Factory implements InterfaceFactory<AndroidOverlayProvider> {
+        public Factory(Context context) {}
+
+        @Override
+        public AndroidOverlayProvider createImpl() {
+            return new AndroidOverlayProviderImpl();
+        }
+    }
+}