Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: media/mojo/interfaces/android_overlay.mojom

Issue 2688193002: Mojo framework for AndroidOverlay. (Closed)
Patch Set: replaced frame id, pid with token Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module media.mojom;
6
7 import "media/mojo/interfaces/media_types.mojom";
8 import "mojo/common/unguessable_token.mojom";
9 import "ui/gfx/geometry/mojo/geometry.mojom";
10
11 interface AndroidOverlayProvider {
dcheng 2017/03/16 08:54:25 Also, some interface level comments that describe
liberato (no reviews please) 2017/03/16 16:53:53 Done.
12 // Create an overlay and send it to |client|, using |config| as the initial
13 // configuration. |overlay| will hold the overlay object.
14 CreateOverlay(AndroidOverlay& overlay, AndroidOverlayClient client, AndroidOve rlayConfig config);
15 };
16
17 // One overlay instance.
18 interface AndroidOverlay {
19 // Cause a layout to occur later.
20 ScheduleLayout(gfx.mojom.Rect rect);
21 };
22
23 // Provided by the client to receive status updates about the overlay.
24 interface AndroidOverlayClient {
25 // |surface_key| is the key that can be used to retrieve the surface via
26 // binder separately.
27 OnSurfaceReady(uint64 surface_key);
28
29 // Indicates that this overlay has been permanently destroyed, or failed to
30 // initialize. It can happen before or after OnSurfaceReady. It will be the
31 // last callback from the overlay in any case.
32 OnDestroyed();
33 };
34
35 // This is not a mirror of AndroidOverlay::Config, since it contains things that
36 // are specific to the mojo implementation.
37 struct AndroidOverlayConfig {
38 mojo.common.mojom.UnguessableToken routing_token;
dcheng 2017/03/16 08:51:39 Nit: please add some comments that describe why ro
liberato (no reviews please) 2017/03/16 16:53:53 Done. TL;DR: it must be sent via IPC for now.
39 gfx.mojom.Rect rect;
40 };
OLDNEW
« media/base/android/android_overlay.h ('K') | « media/mojo/interfaces/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698