Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_dialog.html

Issue 2688153004: ChromeOS OOBE: fix focus flow in MD-OOBE. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_dialog.html
diff --git a/chrome/browser/resources/chromeos/login/oobe_dialog.html b/chrome/browser/resources/chromeos/login/oobe_dialog.html
index 628d8e143422f07186d9fbeb64cc5ca27c8819d0..e136241904ae110ba3266398f29191cd0fe22e53 100644
--- a/chrome/browser/resources/chromeos/login/oobe_dialog.html
+++ b/chrome/browser/resources/chromeos/login/oobe_dialog.html
@@ -11,15 +11,21 @@
three parts: header (which should have <h1>title</h1>), footer (content part),
and optional buttons container at the bottom.
+ When shown (i.e. when outside container calls .show()):
+ 1. If this dialog has tags in class "focus-on-show", the first one will be
+ focused.
+ 2. 'show-dialog' is fired.
+
Example:
<link rel="stylesheet" href="oobe_dialog_parameters.css">
- <oobe-dialog has-buttons>
+ <oobe-dialog on-show-dialog="onTestDialogShown_" has-buttons>
<iron-icon ... class="oobe-icon">
<div class="header">
<h1 class="title">Title</h1>
<div class="subtitle">Subtitle</div>
</div>
<div class="footer">
+ <div class="focus-on-show">...</div>
...
</div>
<div class="bottom-buttons">
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_buttons.js ('k') | chrome/browser/resources/chromeos/login/oobe_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698