Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6530)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_eula.html

Issue 2688153004: ChromeOS OOBE: fix focus flow in MD-OOBE. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_eula.html
diff --git a/chrome/browser/resources/chromeos/login/oobe_eula.html b/chrome/browser/resources/chromeos/login/oobe_eula.html
index 234682ecdf4fbaba5809490a03e5e1064d474827..13db0a79fd41ed94d2494d7f5d8bf3fe7c5a5fed 100644
--- a/chrome/browser/resources/chromeos/login/oobe_eula.html
+++ b/chrome/browser/resources/chromeos/login/oobe_eula.html
@@ -27,21 +27,25 @@
<template>
<link rel="stylesheet" href="oobe_eula.css">
<link rel="stylesheet" href="oobe_dialog_parameters.css">
- <oobe-dialog hidden="[[!eulaLoadingScreenShown]]"
+ <oobe-dialog id="eulaLoadingDialog" hidden="[[!eulaLoadingScreenShown]]"
+ role="dialog" aria-label="$i18n{termsOfServiceLoading}"
has-buttons>
<iron-icon icon="oobe-eula:googleg" class="oobe-icon"></iron-icon>
<div class="header">
<h1 class="title">$i18n{termsOfServiceLoading}</h1>
</div>
</oobe-dialog>
- <oobe-dialog hidden="[[!eulaScreenShown]]"
+ <oobe-dialog id="eulaDialog" hidden="[[eulaLoadingScreenShown]]"
+ role="dialog" aria-label="$i18n{oobeEulaSectionTitle}"
has-buttons>
<iron-icon icon="oobe-eula:googleg" class="oobe-icon"></iron-icon>
<div class="header">
<h1 class="title">$i18n{oobeEulaSectionTitle}</h1>
</div>
<div class="footer flex layout vertical">
- <iframe id="crosEulaFrame" class="flex" src="chrome://terms"
+ <iframe id="crosEulaFrame" src="chrome://terms"
+ role="document" class="flex focus-on-show"
+ aria-label="$i18n{oobeEulaIframeLabel}"
on-load="onFrameLoad_">
</iframe>
<a id="installationSettings" href="#"
@@ -50,7 +54,8 @@
</a>
<div id="logging">
<paper-checkbox aria-labelledby="usage-stats-label" id="usageStats"
- checked="{{usageStatsChecked}}" on-change="onUsageChanged_">
+ checked="{{usageStatsChecked}}" on-change="onUsageChanged_"
+ cclass="focus-on-show">
stevenjb 2017/02/14 01:21:32 class
Alexander Alekseev 2017/02/14 11:59:27 This was disabled on purpose. Thank you! Fixed.
<label id="usage-stats-label">$i18n{checkboxLogging}</label>
<a id="" href="#" on-tap="onUsageStatsHelpLinkClicked_">
$i18n{learnMore}

Powered by Google App Engine
This is Rietveld 408576698