Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 268813005: Fix bug in RenderLayer::scrollsWithRespectTo. (Closed)

Created:
6 years, 7 months ago by chrishtr
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, dsinclair, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Fix bug in RenderLayer::scrollsWithRespectTo. If one layer is a child of the other, but neither scrolls, in some cases it would return incorrectly that one scrolled w.r.t. the other. In particular this would be true if one of the layers was the child of an overflow scroll div. BUG=368410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M LayoutTests/compositing/overflow/scrolls-with-respect-to.html View 3 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/scrolls-with-respect-to-expected.txt View 8 chunks +17 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
chrishtr
6 years, 7 months ago (2014-05-03 00:08:48 UTC) #1
chrishtr
6 years, 7 months ago (2014-05-03 00:14:12 UTC) #2
Ian Vollick
On 2014/05/03 00:14:12, chrishtr wrote: lgtm.
6 years, 7 months ago (2014-05-03 00:47:10 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 7 months ago (2014-05-03 00:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/268813005/1
6 years, 7 months ago (2014-05-03 00:51:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 01:54:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-03 01:54:10 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 7 months ago (2014-05-03 03:54:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/268813005/1
6 years, 7 months ago (2014-05-03 03:54:51 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 04:27:09 UTC) #10
Message was sent while issue was closed.
Change committed as 173265

Powered by Google App Engine
This is Rietveld 408576698