Descriptionapp_list: Another pass of cpplint.py to make it clean.
Reports:
ui/app_list/app_list_model.h:126: Add #include <string> for string
[build/include_what_you_use] [4]
ui/app_list/views/top_icon_animation_view.h:5: #ifndef header guard has
wrong style, please use: UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_
[build/header_guard] [5]
ui/app_list/views/top_icon_animation_view.h:78: #endif line should be
"#endif // UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_"
[build/header_guard] [5]
ui/app_list/views/folder_header_view.cc:169: Add #include <algorithm>
for min [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.cc:320: Add #include <string>
for string [build/include_what_you_use] [4]
ui/app_list/views/app_list_view.h:38: Do not leave a blank line after
"public:" [whitespace/blank_line] [3]
ui/app_list/views/apps_container_view.h:109: Add #include <vector> for
vector<> [build/include_what_you_use] [4]
ui/app_list/views/folder_header_view_delegate.h:26: Add #include
<string> for string [build/include_what_you_use] [4]
ui/app_list/views/apps_grid_view.h:328: Add #include <string> for
string [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.h:93: Add #include <string> for
string [build/include_what_you_use] [4]
ui/app_list/views/search_result_view.h:46: Single-argument constructors
should be marked explicit. [runtime/explicit] [5]
The report was generated by the following command line:
$ find ui/app_list -name "*.cc" -o -name "*.h" | grep -v cocoa | xargs
cpplint.py
After this the total errors found is ZERO!
BUG=337484
TEST=None, no functional changes
TBR=xiyuan@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268003
Patch Set 1 #
Messages
Total messages: 8 (0 generated)
|