Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 268813004: app_list: Another pass of cpplint.py to make it clean. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

app_list: Another pass of cpplint.py to make it clean. Reports: ui/app_list/app_list_model.h:126: Add #include <string> for string [build/include_what_you_use] [4] ui/app_list/views/top_icon_animation_view.h:5: #ifndef header guard has wrong style, please use: UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_ [build/header_guard] [5] ui/app_list/views/top_icon_animation_view.h:78: #endif line should be "#endif // UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_" [build/header_guard] [5] ui/app_list/views/folder_header_view.cc:169: Add #include <algorithm> for min [build/include_what_you_use] [4] ui/app_list/views/app_list_folder_view.cc:320: Add #include <string> for string [build/include_what_you_use] [4] ui/app_list/views/app_list_view.h:38: Do not leave a blank line after "public:" [whitespace/blank_line] [3] ui/app_list/views/apps_container_view.h:109: Add #include <vector> for vector<> [build/include_what_you_use] [4] ui/app_list/views/folder_header_view_delegate.h:26: Add #include <string> for string [build/include_what_you_use] [4] ui/app_list/views/apps_grid_view.h:328: Add #include <string> for string [build/include_what_you_use] [4] ui/app_list/views/app_list_folder_view.h:93: Add #include <string> for string [build/include_what_you_use] [4] ui/app_list/views/search_result_view.h:46: Single-argument constructors should be marked explicit. [runtime/explicit] [5] The report was generated by the following command line: $ find ui/app_list -name "*.cc" -o -name "*.h" | grep -v cocoa | xargs cpplint.py After this the total errors found is ZERO! BUG=337484 TEST=None, no functional changes TBR=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M ui/app_list/app_list_model.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_folder_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/apps_container_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/apps_grid_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/folder_header_view_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/top_icon_animation_view.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
TBRing...
6 years, 7 months ago (2014-05-02 22:05:47 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-02 22:06:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/268813004/1
6 years, 7 months ago (2014-05-02 22:06:56 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 23:12:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 23:12:49 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-02 23:13:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/268813004/1
6 years, 7 months ago (2014-05-02 23:14:30 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:09:00 UTC) #8
Message was sent while issue was closed.
Change committed as 268003

Powered by Google App Engine
This is Rietveld 408576698