chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java - Issue 2688113002: Make ViewRoot the top of the ViewAndroid tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

Issue 2688113002: Make ViewRoot the top of the ViewAndroid tree (Closed)

Patch Set: comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorObserverTestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

index fc86d8d5cbd9c8192b60cb609006a18c3bb18517..b5242423c104ce84b7b4b9dc1ddb98feae302f8a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

@@ -129,14 +129,13 @@ public abstract class FullScreenActivity extends ChromeActivity {

if (tabId != Tab.INVALID_TAB_ID && tabUrl != null && getActivityDirectory() != null) {

// Restore the tab.

TabState tabState = TabState.restoreTabState(getActivityDirectory(), tabId);

- tab = new Tab(tabId, Tab.INVALID_TAB_ID, false, this, getWindowAndroid(),

- TabLaunchType.FROM_RESTORE,

- TabCreationState.FROZEN_ON_RESTORE, tabState);

+ tab = new Tab(tabId, Tab.INVALID_TAB_ID, false, this, getViewRoot(),

+ TabLaunchType.FROM_RESTORE, TabCreationState.FROZEN_ON_RESTORE, tabState);

unfreeze = true;

}

if (tab == null) {

- tab = new Tab(Tab.INVALID_TAB_ID, Tab.INVALID_TAB_ID, false, this, getWindowAndroid(),

+ tab = new Tab(Tab.INVALID_TAB_ID, Tab.INVALID_TAB_ID, false, this, getViewRoot(),

TabLaunchType.FROM_CHROME_UI, null, null);

}