Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4204)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2688113002: Make ViewRoot the top of the ViewAndroid tree (Closed)
Patch Set: comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
index 7090118b39022e7a39275700c0bb711ce71b7d8b..01d1f9bdd1acedf0efb6bbb9658d3c053a8ca661 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
@@ -24,7 +24,7 @@ import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.common.Referrer;
import org.chromium.ui.base.PageTransition;
-import org.chromium.ui.base.WindowAndroid;
+import org.chromium.ui.base.ViewRoot;
/**
* This class creates various kinds of new tabs and adds them to the right {@link TabModel}.
@@ -32,17 +32,16 @@ import org.chromium.ui.base.WindowAndroid;
public class ChromeTabCreator extends TabCreatorManager.TabCreator {
private final ChromeActivity mActivity;
- private final WindowAndroid mNativeWindow;
+ private final ViewRoot mViewRoot;
private final boolean mIncognito;
private TabModel mTabModel;
private TabContentManager mTabContentManager;
private TabModelOrderController mOrderController;
- public ChromeTabCreator(
- ChromeActivity activity, WindowAndroid nativeWindow, boolean incognito) {
+ public ChromeTabCreator(ChromeActivity activity, ViewRoot viewRoot, boolean incognito) {
mActivity = activity;
- mNativeWindow = nativeWindow;
+ mViewRoot = viewRoot;
mIncognito = incognito;
}
@@ -130,8 +129,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
assert TabModelUtils.getTabIndexById(mTabModel, assignedTabId)
== TabModel.INVALID_TAB_INDEX;
- tab = Tab.createLiveTab(assignedTabId, mActivity, mIncognito,
- mNativeWindow, type, parentId, !openInForeground);
+ tab = Tab.createLiveTab(assignedTabId, mActivity, mIncognito, mViewRoot, type,
+ parentId, !openInForeground);
tab.initialize(
webContents, mTabContentManager, delegateFactory, !openInForeground, false);
tab.setParentIntent(parentIntent);
@@ -140,12 +139,12 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
// On low memory devices the tabs opened in background are not loaded automatically
// to preserve resources (cpu, memory, strong renderer binding) for the foreground
// tab.
- tab = Tab.createTabForLazyLoad(mActivity, mIncognito, mNativeWindow, type,
- parentId, loadUrlParams);
+ tab = Tab.createTabForLazyLoad(
+ mActivity, mIncognito, mViewRoot, type, parentId, loadUrlParams);
tab.initialize(null, mTabContentManager, delegateFactory, !openInForeground, false);
} else {
- tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
- mNativeWindow, type, parentId, !openInForeground);
+ tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito, mViewRoot, type,
+ parentId, !openInForeground);
tab.initialize(null, mTabContentManager, delegateFactory, !openInForeground, false);
tab.loadUrl(loadUrlParams);
}
@@ -178,8 +177,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
boolean openInForeground = mOrderController.willOpenInForeground(type, mIncognito);
TabDelegateFactory delegateFactory = parent == null ? createDefaultTabDelegateFactory()
: parent.getDelegateFactory();
- Tab tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
- mNativeWindow, type, parentId, !openInForeground);
+ Tab tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito, mViewRoot, type,
+ parentId, !openInForeground);
tab.initialize(webContents, mTabContentManager, delegateFactory, !openInForeground, false);
mTabModel.addTab(tab, position, type);
return true;
@@ -277,7 +276,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
@Override
public Tab createFrozenTab(TabState state, int id, int index) {
Tab tab = Tab.createFrozenTabFromState(
- id, mActivity, state.isIncognito(), mNativeWindow, state.parentId, state);
+ id, mActivity, state.isIncognito(), mViewRoot, state.parentId, state);
boolean selectTab = mOrderController.willOpenInForeground(TabLaunchType.FROM_RESTORE,
state.isIncognito());
tab.initialize(

Powered by Google App Engine
This is Rietveld 408576698