Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4663)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2688113002: Make ViewRoot the top of the ViewAndroid tree (Closed)
Patch Set: comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index b1fe5a24990f77fcc9fe553cbf2030baa6419b53..d949995a492c69699a3df47e30b2aade4a53288e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -146,6 +146,7 @@ import org.chromium.printing.PrintingControllerImpl;
import org.chromium.ui.base.ActivityWindowAndroid;
import org.chromium.ui.base.DeviceFormFactor;
import org.chromium.ui.base.PageTransition;
+import org.chromium.ui.base.ViewRoot;
import org.chromium.ui.base.WindowAndroid;
import java.util.ArrayList;
@@ -226,6 +227,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
private ProfileSyncService.SyncStateChangedListener mSyncStateChangedListener;
private ActivityWindowAndroid mWindowAndroid;
+ private ViewRoot mViewRoot;
private ChromeFullscreenManager mFullscreenManager;
private boolean mCreatedFullscreenManager;
@@ -282,6 +284,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
getWindow().setBackgroundDrawable(getBackgroundDrawable());
mWindowAndroid = new ChromeWindow(this);
mWindowAndroid.restoreInstanceState(getSavedInstanceState());
+ mViewRoot = ViewRoot.create(mWindowAndroid);
mFullscreenManager = createFullscreenManager();
mCreatedFullscreenManager = true;
@@ -670,7 +673,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
setTabContentManager(new TabContentManager(this, getContentOffsetProvider(),
DeviceClassManager.enableSnapshots()));
- mCompositorViewHolder.onNativeLibraryReady(mWindowAndroid, getTabContentManager());
+ mCompositorViewHolder.onNativeLibraryReady(mViewRoot, getTabContentManager());
if (isContextualSearchAllowed() && ContextualSearchFieldTrial.isEnabled()) {
mContextualSearchManager = new ContextualSearchManager(this, mWindowAndroid, this);
@@ -1003,6 +1006,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (selector != null) selector.destroy();
}
+ if (mViewRoot != null) {
+ mViewRoot.destroy();
+ mViewRoot = null;
+ }
+
if (mWindowAndroid != null) {
mWindowAndroid.destroy();
mWindowAndroid = null;
@@ -1435,6 +1443,13 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
/**
+ * @return A {@link ViewRoot} instance.
+ */
+ public ViewRoot getViewRoot() {
+ return mViewRoot;
+ }
+
+ /**
* @return A {@link WindowAndroid} instance.
*/
public WindowAndroid getWindowAndroid() {

Powered by Google App Engine
This is Rietveld 408576698