Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2688073002: MD Settings: For rows containing paper-toggle-buttons, make entire row clickable. (Closed)
Patch Set: convert a more complicated row Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index 8e0c4b029c5ad5253e57388a4c64b732355b14aa..c4901455afbd5377b955283464a58f184768e580 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -114,8 +114,11 @@ Polymer({
// <if expr="_google_chrome and not chromeos">
/** @private */
onMetricsReportingControlTap_: function() {
+ if(this.metricsReporting_.managed)
+ return;
+
var browserProxy = settings.PrivacyPageBrowserProxyImpl.getInstance();
- var enabled = this.$.metricsReportingControl.checked;
+ var enabled = !this.metricsReporting_.enabled;
browserProxy.setMetricsReportingEnabled(enabled);
},
@@ -144,7 +147,7 @@ Polymer({
/** @private */
onSafeBrowsingExtendedReportingControlTap_: function() {
var browserProxy = settings.PrivacyPageBrowserProxyImpl.getInstance();
- var enabled = this.$.safeBrowsingExtendedReportingControl.checked;
+ var enabled = !this.safeBrowsingExtendedReportingEnabled_;
browserProxy.setSafeBrowsingExtendedReportingEnabled(enabled);
},

Powered by Google App Engine
This is Rietveld 408576698