MD Settings: For rows containing paper-toggle-buttons, make entire row clickable.

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 4bf462434a60e6f650baab76ea9c82b6e52718f2..a3c026c88c82ab8e03d283994569e8573eca35cd 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -81,10 +81,11 @@
               label="$i18n{networkPredictionEnabled}">
           </settings-toggle-button>
         </div>
-        <div class="settings-box">
+        <div class="settings-box" actionable
+            on-tap="onSafeBrowsingExtendedReportingControlTap_">
           <div class="start">$i18n{safeBrowsingEnableExtendedReporting}</div>
           <paper-toggle-button id="safeBrowsingExtendedReportingControl"
-              on-tap="onSafeBrowsingExtendedReportingControlTap_"
+              on-change="onSafeBrowsingExtendedReportingControlTap_"
               checked="[[safeBrowsingExtendedReportingEnabled_]]">
           </paper-toggle-button>
         </div>
@@ -104,7 +105,8 @@
         </div>
 </if><!-- chromeos -->
 <if expr="not chromeos">
-        <div class="settings-box">
+        <div class="settings-box" on-tap="onMetricsReportingControlTap_"

[Dan Beam, 2017/02/10 07:11:36]

this changes the clickable area (compared to other rows implemented with
<settings-toggle-button>)

[Dan Beam, 2017/02/10 07:11:36]

when you tap the box, you want to invert the value

+            actionable$="[[!metricsReporting_.managed]]">
           <div class="start">$i18n{enableLogging}</div>
           <template is="dom-if" if="[[showRestart_]]" restamp>
             <paper-button on-tap="onRestartTap_" id="restart">
@@ -119,7 +121,7 @@
             </paper-tooltip>
           </template>
           <paper-toggle-button id="metricsReportingControl"
-              on-tap="onMetricsReportingControlTap_"
+              on-change="onMetricsReportingControlTap_"

[Dan Beam, 2017/02/10 07:11:36]

but when this changes, you DON'T want to invert the value (it just changed)

[Dan Beam, 2017/02/10 07:11:36]

this doesn't work when you drag the toggle

[Dan Beam, 2017/02/10 07:14:51]

allllso, when you tap on the toggle, you get double events

first, you get this change event

THEN, you get the on-tap of the parent.

[scottchen, 2017/02/10 18:49:57]

Acknowledged. Fixed with a later patch.

[scottchen, 2017/02/10 18:49:57]

on-tap doesn't fire, but on-change seems to fire when dragged.

[scottchen, 2017/02/10 18:49:57]

depends on which value. You don't wanna invert .checked, but you do wanna invert
metricsReporting_.enabled; based on my experiment, changing the checkbox value
doesn't change metricsReporting_.enabled unless the handler says to do so
(assuming checked= is one-way bounded). This is also why if you just have
on-tap, dragging doesn't work in two windows.

               checked="[[metricsReporting_.enabled]]"
               disabled="[[metricsReporting_.managed]]">
           </paper-toggle-button>