chrome/browser/resources/settings/privacy_page/privacy_page.html - Issue 2688073002: MD Settings: For rows containing paper-toggle-buttons, make entire row clickable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2688073002: MD Settings: For rows containing paper-toggle-buttons, make entire row clickable. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html

diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html

index 4bf462434a60e6f650baab76ea9c82b6e52718f2..6871e2d42dec17a83116814bc2e6df7c57695a68 100644

--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html

+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -81,10 +81,11 @@

label="$i18n{networkPredictionEnabled}">

</settings-toggle-button>

</div>

- <div class="settings-box">

+ <div class="settings-box" actionable

+ on-tap="onSafeBrowsingExtendedReportingControlTap_">

<div class="start">$i18n{safeBrowsingEnableExtendedReporting}</div>

<paper-toggle-button id="safeBrowsingExtendedReportingControl"

- on-tap="onSafeBrowsingExtendedReportingControlTap_"

+ on-change="onSafeBrowsingExtendedReportingControlTap_"

scottchen 2017/02/10 06:51:02 This is needed to handle dragging, since on-tap do

checked="[[safeBrowsingExtendedReportingEnabled_]]">

</paper-toggle-button>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »