Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2551)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2688053003: Record Autofill form events specially for nonsecure pages (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 0365ba42a5f56b305d1e52d39317ee0eea746a7a..977e67ae874903559f8db8b28cd66a3866331b41 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -566,7 +566,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
std::vector<Suggestion> suggestions;
const bool is_context_secure =
!form_structure ||
- (client_->IsContextSecure(form_structure->source_url()) &&
+ (client_->IsContextSecure() &&
(!form_structure->target_url().is_valid() ||
!form_structure->target_url().SchemeIs("http")));
const bool is_http_warning_enabled =
@@ -1439,6 +1439,8 @@ bool AutofillManager::RefreshDataModels() {
is_server_data_available);
credit_card_form_event_logger_->set_is_local_data_available(
is_local_data_available);
+ credit_card_form_event_logger_->set_is_context_secure(
+ client_->IsContextSecure());
}
{
bool is_server_data_available = false;
« no previous file with comments | « components/autofill/core/browser/autofill_client.h ('k') | components/autofill/core/browser/autofill_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698