Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: cc/surfaces/surface_manager.cc

Issue 2688043002: Retain references to surfaces from both active AND pending CompositorFrames (Closed)
Patch Set: Added TODOs and addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_dependency_tracker.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index c91bf2cb617bef011f317c6cd7e1ed683402c6d1..f7e3119eb375b978ff7be255e5a77231f57dc509 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -327,7 +327,9 @@ SurfaceManager::SurfaceIdSet SurfaceManager::GetLiveSurfacesForSequences() {
Surface* surf = surface_map_[live_surfaces[i]];
DCHECK(surf);
- for (const SurfaceId& id : surf->referenced_surfaces()) {
+ // TODO(fsamuel): We should probably keep alive pending referenced surfaces
+ // too.
+ for (const SurfaceId& id : surf->active_referenced_surfaces()) {
if (live_surfaces_set.count(id))
continue;
« no previous file with comments | « cc/surfaces/surface_dependency_tracker.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698