Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/test/content_browser_test_utils_internal.cc

Issue 2688043002: Retain references to surfaces from both active AND pending CompositorFrames (Closed)
Patch Set: Added TODOs and addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/content_browser_test_utils_internal.h" 5 #include "content/test/content_browser_test_utils_internal.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 break; 317 break;
318 } 318 }
319 } 319 }
320 320
321 bool SurfaceHitTestReadyNotifier::ContainsSurfaceId( 321 bool SurfaceHitTestReadyNotifier::ContainsSurfaceId(
322 cc::SurfaceId container_surface_id) { 322 cc::SurfaceId container_surface_id) {
323 if (!container_surface_id.is_valid()) 323 if (!container_surface_id.is_valid())
324 return false; 324 return false;
325 for (cc::SurfaceId id : 325 for (cc::SurfaceId id :
326 surface_manager_->GetSurfaceForId(container_surface_id) 326 surface_manager_->GetSurfaceForId(container_surface_id)
327 ->referenced_surfaces()) { 327 ->active_referenced_surfaces()) {
328 if (id == target_view_->SurfaceIdForTesting() || ContainsSurfaceId(id)) 328 if (id == target_view_->SurfaceIdForTesting() || ContainsSurfaceId(id))
329 return true; 329 return true;
330 } 330 }
331 return false; 331 return false;
332 } 332 }
333 333
334 NavigationStallDelegate::NavigationStallDelegate(const GURL& url) : url_(url) {} 334 NavigationStallDelegate::NavigationStallDelegate(const GURL& url) : url_(url) {}
335 335
336 void NavigationStallDelegate::RequestBeginning( 336 void NavigationStallDelegate::RequestBeginning(
337 net::URLRequest* request, 337 net::URLRequest* request,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 NavigationHandle* navigation_handle) { 392 NavigationHandle* navigation_handle) {
393 if (navigation_handle->HasCommitted() && 393 if (navigation_handle->HasCommitted() &&
394 !navigation_handle->IsErrorPage() && 394 !navigation_handle->IsErrorPage() &&
395 navigation_handle->GetURL() == url_ && 395 navigation_handle->GetURL() == url_ &&
396 navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) { 396 navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) {
397 run_loop_.Quit(); 397 run_loop_.Quit();
398 } 398 }
399 } 399 }
400 400
401 } // namespace content 401 } // namespace content
OLDNEW
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698